Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MaxPubAcksInFlight option #88

Merged
merged 1 commit into from
Jul 15, 2016
Merged

Add MaxPubAcksInFlight option #88

merged 1 commit into from
Jul 15, 2016

Conversation

kozlovic
Copy link
Member

@kozlovic kozlovic commented Jul 9, 2016

Resolves #82

@coveralls
Copy link

coveralls commented Jul 9, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 86.383% when pulling bcd0e33 on add_max_pub_acks_in_flight_option into 59d0676 on master.

@kozlovic
Copy link
Member Author

/cc @mcqueary Is this ok for issue #82? Do you think the name of the function setting the option is ok?

@ColinSullivan1
Copy link
Member

LGTM

1 similar comment
@aricart
Copy link
Member

aricart commented Jul 15, 2016

LGTM

@kozlovic kozlovic mentioned this pull request Jul 15, 2016
Merged
@kozlovic kozlovic merged commit c3ced71 into master Jul 15, 2016
@kozlovic kozlovic deleted the add_max_pub_acks_in_flight_option branch July 15, 2016 15:47
kozlovic added a commit that referenced this pull request Jul 15, 2016
@kozlovic
[CHANGED] MaxPubAcksInFlight to MaxPubAcksInflight
d524023 
The introduced option setter had a case that did not match the
option it is setting and the similar Subscription's option
MaxInflight

Related to PR #88
@kozlovic kozlovic mentioned this pull request Jul 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kozlovic @coveralls @ColinSullivan1 @aricart