-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show brew system tags on user page brew items #1842
Comments
Hold off unless there is an obvious and simple incremental PR. There is work in progress on brew.tags, of which brew.systems is arguably a subset of. That's a much bigger piece of work though, so maybe don't hold off. |
I'm reviewing @G-Ambatte 's PR #2330, and all the work on sprucing up the User page is looking great. I just had some thoughts and want to see what the consensus is: As @ericscheid points out, Systems are kind of a subset of Tags, so I ask you all:
|
Not worth letting that happen. Implementing a In approximate order..
|
I would say merging them into tags is better approach. It is more extendible than having separate property for each potential brew properties. I suppose that tags should be easily searchable, so we should be able to setup some filters over properties-as-tags without them being separate properties.
I honestly don't know how that area looks like now and haven't looked in there yet, but I suppose that we could show only a couple of tags by default and add a button to toggle it into a full list.
I think that we might want such property-as-tag tags to have special format (something like "property:value", for example). That coupled with an auto-complete over most used values should prevent the list of possible values to grow too huge. Plus, I suppose that maintaining a list of supported property-as-tags is a less burden than also maintaining a list of values allowed in there. With auto-complete, users should be able to define "a standard" version of property-as-tags values themselves simply because that the most used one will show up in auto-complete more and therefore it will be used more often, eliminating less popular spellings. |
We already support Tags that have the syntax of NOTE: styling of tags per category can be achieved vis CSS: .brewItem .brewTags span.system { border-color: red; }
.brewItem .brewTags span.type { border-color: blue; }
.brewItem .brewTags span.meta { border-color: green; } |
Btw, if we're looking at merging the brew.systems object into brew.tags, can we take care to be more explicit with the literal values. Having For example: I use HB for my Also, we need to add |
Styling of tags per category is now possible, though not yet deployed to production. |
From #240
.brewItem div.info
to show the system tags (if any)<span title="System: 5e">5e</span>
or similarUPDATE: implemented via
brew.tags
The text was updated successfully, but these errors were encountered: