Add tag filtering #3165
Merged
Add tag filtering #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Ambatte
added
the
P2 - minor feature or not urgent
|
Looking great, all we need is UI feedback/status to show that the userpage is currently filtered by tags. I'm imagining a 2nd userpage utility bar that appears when tag filtering is in effect. 
|
G-Ambatte
added
🔍 R4 - Reviewed - Fixed! ⭐
5e-Cleric
approved these changes
Feb 22, 2024
|
Remove that last console log and i think this is done, merging in 24 hours if nobody says otherwise. |
Gotta be honest, not sure how this one can go sideways, or how to test it other than using it, i already reported one issue, but it is outside of the scope of this PR, and taking care of it in #3284, albeit could use some help with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #3164.
It adds the
updateListFilterfunction to the BrewItem component, allowing it to update the filter in the upstream ListPage.This function currently takes two arguments,
typeandterm. In the current implementation,typeis unused, andtermis applied to the existing text filter.