-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter brews by clicking tags #3164
Comments
The relevant code to tweak is at homebrewery/client/homebrew/pages/basePages/listPage/brewItem/brewItem.jsx Lines 127 to 134 in be72b02
We could simply apply a html link, but that would entail a server round trip http request. Better would be to do a |
I think we need to pass a function from ListPage to BrewItem to allow it to be able to influence the filtering. I suspect the easiest thing to do will be to just replace the current filter with the tag contents, but then we should be able to extend to allow the text input to co-exist with a tag filter. |
Reading back through the history on this, we never actually created this functionality. I believe we can probably do so by making the tags automatically link to the current URL with a
?filter=${URL.encode(tag content)}
.Originally posted by @G-Ambatte in #758 (comment)
The text was updated successfully, but these errors were encountered: