-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS Commenting + New "Style Editor" snippet menu #1572
CSS Commenting + New "Style Editor" snippet menu #1572
Conversation
And other tweaks: - Move drop caps snippets to Style Editor menu - retitle Editor menu to either Text Editor or Style Editor - minor: removed old unnecessary comments in code from earlier (my own). - Removed leading spaces on drop cap comment - added drop cap comment on "remove drop caps" snippet.
Matching legacy to v3 (adds another menu to style editor, etc).
Removed reference to hotkeys for commenting in the Style Editor since that is not implemented yet. can be added back to match the Text Editor commenting snippet once implemented.
Yes we should do this but it can be a separate PR to avoid cluttering this one up. We would just need to pass in the |
and change v3 drop cap to use only `background` rather than `background-image` so that the tweak snippet can easily change between gradient and just a regular color. and re-order table menu so that the regular table snippet is at top.
Just remembered you asked for some dedents here, working on that. Out of curiosity, what is the difference between this:
and:
I see both are used, but no obvious difference. |
having `.pages` included in the selector did not match the selectivity in the base .less sheet. Oddly, it was working in the Edit Page, but not in the Print Page.
No real difference. The way it's processed is slightly different, but the result is the same. Probably cleanest to just not use As for
vs
They are handled the same; |
Changing to just `background` undoes `background-clip` as well. This is more explicit.
Merged! Thanks @Gazook89 🎉 |
This builds on PR #1562, awaiting approval.
*my local docker build has issues with font-awesome icons...
Changes
Places for improvement
Commenting hotkeys should be updated to reflect the editor pane that is open, so html comments are used in the Text Editor and css comments are used in the Style Editor.