-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Vault page (search published brews) (alt title Archive) #3263
Merged
calculuschild
merged 232 commits into
naturalcrit:master
from
5e-Cleric:experimental-development
Sep 4, 2024
Merged
[FEATURE]: Vault page (search published brews) (alt title Archive) #3263
calculuschild
merged 232 commits into
naturalcrit:master
from
5e-Cleric:experimental-development
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5e-Cleric
changed the title
Admin page tinkering
Admin fix & Archive page (search published brews)
Jan 22, 2024
Closed
3 tasks
5e-Cleric
changed the title
Admin fix & Archive page (search published brews)
[FEATURE]: Archive page (search published brews)
Jan 23, 2024
toDo list:
|
…ic/homebrewery into experimental-development
…andler already prints the error)
`performSearch` will set PageState whether `update` is true or not, so this line here is not doing anything.
Now `update` is unused; can remove that parameter.
No longer naming conflict with state and function parameters. We can go back to the shorter names
`performSearch()` and `loadTotal()` shouldn't need a separate check for valid items if `loadPage` already does it through `validateForm`
calculuschild
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have made all my tweaks.
Just one more set of issues I found that crash the page when trying to render an error message. Feel free to merge after fixing.
All fixed again |
Hiding the `moveBrew` etc. properties when `this.state.showMoveArrows == false` means when the `metaData` tab turns off the arrows it crashes because now some functions are undefined. Just using a whole separate property to avoid conflict.
Gonna merge now..... Good work @5e-Cleric . This is a big one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just me trying to create the most wanted function, find published brews by title.
This PR creates a new Page, called the vault page, it also creates a new API endpoint to get files based of title, with multiple additional filters.
As per last update, has 2 separate request that are run simultaneously in first load of query, then only one of them is run with every reload. This avoids timeouts.
Added files and their functions:
vaultPage.jsx
vaultPage.less
vault.api.js
vault.navitem.jsx
Modified files:
homebrew.jsx
: added Route for the pagebrewItem.jsx
: modified author display to show 'no authors';app.js
: added vault error handlinghomepage.jsx
&userpage.jsx
: added nav item to vaultsplitPane.jsx
: hide arrows if prophideMoveArrows
Changes
For a next PR
ToDo in this PR
Testing:
I don't know what else to test.