Improved Automatic Brew thumbnail generation option #3501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of the code works *IF* all CSS URLs are relocated to trusted locations - IE, the local server. After this I will be continuing my work attempting to do URL rewrites for arbitrary purposes in support of this PR and direct PDF creation.
This feature works in two parts. This first part is by adding a prioxy-passthrough for resources. This enables the code to get around XSS issues we were previously having,. The second part clones the first page, massages URLs in it's <Links>, <style>, and <img> tags to use the L to load the resources then generate two thumbnails. One is 115px tall and the other is set at 50% the page height. Currently, only the smaller of the two is stored as a new BrewStub field.
|
Closes #2278 to some degree. |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #3219.
This is a feature addition that adds the option of creating a thumbnail directly from the first page of the brew.
This feature had issues with XSS support/non-support at various offsite resources. This PR resolves that issue by creating a proxy endpoint that loads for those resources.
An additional field, thumbnailSm, has been added to the brewStub schema to hold this data, if used.