-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Automatic Brew thumbnail generation option #3501
Open
dbolack-ab
wants to merge
15
commits into
naturalcrit:master
Choose a base branch
from
dbolack-ab:proxycache_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on May 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 757514c - Browse repository at this point
Copy the full SHA 757514cView commit details -
Img substitution generates correct URLs but the substitution load seems to fail?
Configuration menu - View commit details
-
Copy full SHA for ae96ac7 - Browse repository at this point
Copy the full SHA ae96ac7View commit details
Commits on May 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a095ab9 - Browse repository at this point
Copy the full SHA a095ab9View commit details
Commits on May 29, 2024
-
Saving a functional but non-function in production point.
This version of the code works *IF* all CSS URLs are relocated to trusted locations - IE, the local server. After this I will be continuing my work attempting to do URL rewrites for arbitrary purposes in support of this PR and direct PDF creation.
Configuration menu - View commit details
-
Copy full SHA for 8e05e63 - Browse repository at this point
Copy the full SHA 8e05e63View commit details -
This feature works in two parts. This first part is by adding a prioxy-passthrough for resources. This enables the code to get around XSS issues we were previously having,. The second part clones the first page, massages URLs in it's <Links>, <style>, and <img> tags to use the L to load the resources then generate two thumbnails. One is 115px tall and the other is set at 50% the page height. Currently, only the smaller of the two is stored as a new BrewStub field.
Configuration menu - View commit details
-
Copy full SHA for 492537d - Browse repository at this point
Copy the full SHA 492537dView commit details -
Configuration menu - View commit details
-
Copy full SHA for edbec26 - Browse repository at this point
Copy the full SHA edbec26View commit details
Commits on Jun 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 58a1272 - Browse repository at this point
Copy the full SHA 58a1272View commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eeeda88 - Browse repository at this point
Copy the full SHA eeeda88View commit details
Commits on Jul 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c3c5e41 - Browse repository at this point
Copy the full SHA c3c5e41View commit details
Commits on Jul 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4d2c544 - Browse repository at this point
Copy the full SHA 4d2c544View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6269cd3 - Browse repository at this point
Copy the full SHA 6269cd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd28756 - Browse repository at this point
Copy the full SHA fd28756View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36e2105 - Browse repository at this point
Copy the full SHA 36e2105View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2485b3 - Browse repository at this point
Copy the full SHA c2485b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60e0c8b - Browse repository at this point
Copy the full SHA 60e0c8bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.