Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xform_brain should not require an explicit target specification for image data #16

Closed
jefferis opened this issue Oct 15, 2015 · 4 comments

Comments

@jefferis
Copy link
Contributor

Error:

xform_brain("/Volumes/teraraid/flybrain/Shahar/SplitRegistration/IS2/reformatted/IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd", ref=JFRC2, sample=IS2, outfile=path.expand("~/projects/Shahar/Screen/AdditionalOutputs/JFRC2_IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd"))

Error in basename(as.character(f)) :
argument "target" is missing, with no default

OK:

xform_brain("/Volumes/teraraid/flybrain/Shahar/SplitRegistration/IS2/reformatted/IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd", ref=JFRC2, sample=IS2, target=JFRC2, outfile=path.expand("~/projects/Shahar/Screen/AdditionalOutputs/JFRC2_IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd"))
Reading transformation from studylist /Library/Frameworks/R.framework/Versions/3.2/Resources/library/nat.flybrains/extdata/bridgingregistrations/JFRC2_IS2.list
WARNING: image does not have valid orientation meta information; cannot reorient.
cmd:
'/usr/local/lib/cmtk/bin/reformatx' --verbose --outfile '/Volumes/teraraid/flybrain/Shahar/SplitRegistration/IS2/reformatted/JFRC2_IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd' --floating '/Volumes/teraraid/flybrain/Shahar/SplitRegistration/IS2/reformatted/IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd' --interpolation linear --outfile '/Volumes/teraraid/flybrain/Shahar/SplitRegistration/IS2/reformatted/JFRC2_IS2_JK733SF457-1_02_warp_m0g80c8e1e-1x26r4.nrrd' --target-grid 1024,512,218:0.622088,0.622088,0.622088:0.000000,0.000000,0.000000 '/Library/Frameworks/R.framework/Versions/3.2/Resources/library/nat.flybrains/extdata/bridgingregistrations/JFRC2_IS2.list'

(moved from natverse/nat.flybrains#30)

@jefferis jefferis changed the title xform_brain should not require an explicit target specification for image data enhancement xform_brain should not require an explicit target specification for image data Oct 15, 2015
@jefferis
Copy link
Contributor Author

jefferis commented Sep 9, 2016

Could do this by adding a target argument (which is sometimes ignored) or modifying ...

see http://stackoverflow.com/questions/16321760/r-change-value-of-an-argument-in-ellipsis-and-pass-ellipsis-to-the-other-functi
for how to do that.

@jefferis
Copy link
Contributor Author

jefferis commented Feb 5, 2018

@rrbenton this is a bug that you would like closed.

@jefferis jefferis added the bug label Feb 5, 2018
@jefferis
Copy link
Contributor Author

jefferis commented Apr 30, 2019

@mmc46 this is interesting for you as well. Do you want to check

devtools::install_github("jefferislab/nat.templatebrains@feature/auto-target")

and see if it works for your use case without having to specify target explicitly.

@mmc46
Copy link

mmc46 commented Apr 30, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants