Prune #403
Merged
Prune #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexanderbates
commented
Jul 19, 2019
alexanderbates
commented
- Prune neuron interactively
- Prune neuron within a volume
* Interactively re-reoot a neuron, or neurons in a neuronlist, by choosing a more appropriate leaf node
* Generate a 3D model from connector and/or tree node data
* master: dev: travis build status should be for master branch redown Bump version/NEWS dev: ignore spare directory Spelling
* since it will often already be a surface * also check that input is an hxsurf if neuropil argument is non-null
* also remove references in example to interactive pruning (this isn't)
* new groupings for 3d/interactive functions * still need to regenerate
* causes latex error on travis, so not worth it
* this means you can set up the scene at the start rather than continually replotting it
* we need this now since we don't blast the plot repeatedly with clear3d
* i.e. the fact that select_points no longer clears * also make prune_online use pop rather than clear
* @alexanderbates back to you to fix
|
I think the conclusion is that |
|
Thanks @alexanderbates! Could you fix a couple of doc typos and re-roxygenise? chossign make_model.Rd:21 |
jefferis
reviewed
Aug 6, 2019
NAMESPACE
Outdated
| export(xformimage) | ||
| export(xformpoints) | ||
| export(xyzmatrix) | ||
| export(xyzpos) | ||
| import(grDevices) |
There was a problem hiding this comment.
I'm not quite sure how this all got deleted two commits back ...
jefferis
reviewed
Aug 6, 2019
R/interactive.R
Outdated
| @@ -21,8 +21,7 @@ | |||
| #' @export | |||
| #' @rdname prune_online | |||
| prune_online <-function(x, ...) UseMethod("prune_online") | |||
| #' @export | |||
| #' @rdname prune_online | |||
|
|
|||
There was a problem hiding this comment.
I think they need to be exported. Was there a reason not to? NB this has a different meaning for methods vs functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.