Improved support for neurons as meshes (WIP) #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jefferis
commented
Aug 14, 2020
jefferis
commented
- still need to work on 3D display
* with tests
* this is what we need when plotting meshes and is implicit in all the other plot methods
* I don’t think it adds much and will be v slow for meshes
* use this in tests
* fixes needed due to one overlapping change in code and several doc overlaps Conflicts: R/neuronlist.R man/plot3d.boundingbox.Rd man/plot3d.cmtkreg.Rd man/plot3d.dotprops.Rd man/plot3d.neuron.Rd man/plot3d.neuronlist.Rd
* of course this might be possible using polylines or some strategy that "filled out" skeletons based on radius info if that were actually reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.