Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor accounting in Rust #1755

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Refactor accounting in Rust #1755

merged 1 commit into from
Jun 30, 2024

Conversation

filipmacek
Copy link
Collaborator

@filipmacek filipmacek commented Jun 29, 2024 •
edited

Pull Request

  • To create AccountAny whole accounting crate content needed to be moved to model crate
  • Box<dyn Account>> is replaced with AccountAny across the Rust codebase

@filipmacek filipmacek added the rust Relating to the Rust core label Jun 29, 2024
@filipmacek filipmacek self-assigned this Jun 29, 2024
cjdsellers
cjdsellers approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this move, we're choosing performance over abstraction.

A potentially better location is the common crate, but this remains to be decided as we can still afford to shuffle things around.

@cjdsellers cjdsellers changed the title Rust accounting refactoring Refactor accounting in Rust Jun 30, 2024
@cjdsellers cjdsellers merged commit 5839ea8 into develop Jun 30, 2024
9 checks passed
@cjdsellers cjdsellers deleted the rust-accounting-refactor branch June 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdsellers cjdsellers cjdsellers approved these changes

Assignees

@filipmacek filipmacek

Labels
rust Relating to the Rust core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filipmacek @cjdsellers