Support file upload #110
Merged
Support file upload #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecAivazis
requested changes
Sep 8, 2020
There was a problem hiding this comment.
Hey @obukhov - thanks for submitting this (and the corresponding one on nautilus/graphql). A few small comments but we should be able to get this in quickly once those tests are ready
|
@AlecAivazis finished with tests can you please have a look? |
|
Hi @AlecAivazis! Sorry for pinging you, I saw you are busy. Any update on this one? |
|
No worries about pinging me. Thanks for the reminder :) I will pull this down today and test it. Things looks good from a code perspective so we should be able to get this in very quickly |
AlecAivazis
requested changes
Sep 20, 2020
AlecAivazis
reviewed
Sep 20, 2020
AlecAivazis
reviewed
Sep 20, 2020
AlecAivazis
reviewed
Sep 20, 2020
| @@ -1,13 +1,18 @@ | |||
| package gateway | |||
There was a problem hiding this comment.
thank you so much for writing these tests!!
AlecAivazis
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #103
It requires the following PR to be merged first: nautilus/graphql#13
Introduces compatibility with multipart/form-data requests for file uploads according to the following specification: