Add sign_inputs and Transaction reviewing improvements
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In some cases, there is no appropriate change box. This commit fixes the behaviour where a box was considered to be a change box even though it contained non-change assets. This was because the change box was simply determined by taking the last output going to own address. * Participants inputs are aggregated and if an output going to own address exists and it only includes assets from aggregation of own inputs, this output is marked as change box. * For multiwitness txs, there can be different change boxes for each participant (the wallet always selects the change box in respect to the participant).
* Change boxes are selected greedily while their sum is not more than sum of own inputs. * The set of change boxes might not be unique, but the greedy solution finds one of the sets that is maximal in terms of inclusion. * In an attempt to include as many tokens as possible in change, we consider outputs in order of decreasing number of different tokens. For example, if there are two valid maximal change box sets, one containing a single box with token A and the second containing many different tokens, we prefer the second one.
Co-authored-by: capt-nemo429 <96133754+capt-nemo429@users.noreply.github.com>
Fix change box handling in tx interpreter
* No ERG present among tokens yet
* ERG is always displayed first now. * Use BigNumber methods instead of BigInts. * Remove redundant comments, add some new.
* Move delta calculation from TxSignSummary to txInterpreter. * Expose new properties totalIncoming and totalLeaving in txInterpreter. * Use utxoSum and utxoSumResultDiff for deltas calculation. * Extract some parts of the calculation to a separate utils file under transaction interpreter. * Some local functions defined in _determineChangeBoxes in txInterpreter were also needed for _calcIncomingLeavingTotals, so there are slight changes to change box function as well.
Add display of wallet changes to TxSignView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.