1.2 Rollup #13
Merged
1.2 Rollup #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: yamllint
- [Based on](nautobot/nautobot-app-secrets-providers#100). - Fixed invoke tasks: - Don't specify nautobot config for `invoke check-migrations` - Arguments added to invoke tasks: - `invoke unittest --verbose` - `invoke tests --keepdb` - `invoke tests --lint-only` - Removed obsolete environment variables: - `NAUTOBOT_DJANGO_EXTENSIONS_ENABLED` - `NAUTOBOT_DJANGO_TOOLBAR_ENABLED` - Better organized `development/nautobot_config.py` file. - Removed unnecessary linter rules. - Moved `Debug` section to the top, to be easily reused. - Moved `Redis` section next to `Database` section. - Renamed `TESTING` to `_TESTING` as it's the local variable only. - Removed `RQ` related comments. - Renamed `plugin` => `App` in comments. - Removed obsoleted commented out docker-compose postgres mount `nautobot.sql`. - Alphabetically sorted requirements and removed obvious comments. - Aligned nautobot-plugin and nautobot-plugin-ssot templates: - `development/nautobot_config.py` - invoke tasks - docs requirements and configuration fix: Tasks formatting fix: Use `plugin_slug` for compose project name
Update nautobot-plugin/{{ cookiecutter.project_slug }}/pyproject.toml
Co-authored-by: Christian Adell <chadell@gmail.com>
Address review feedback
Update docs links
Update link
Copy changes to ssot template
|
@itdependsnetworks @snaselj Please do a once over here. I tried to grab everyone's pending contributions in the private template. If this looks good, I can go ahead and mint a new version of the template here and update the other repo to redirect everyone here. |
nautobot-app/{{ cookiecutter.project_slug }}/docs/dev/dev_environment.md
Show resolved
Hide resolved
nautobot-app/{{ cookiecutter.project_slug }}/docs/requirements.txt
Outdated
Show resolved
Hide resolved
snaselj
reviewed
Sep 1, 2023
nautobot-app/{{ cookiecutter.project_slug }}/.github/workflows/rebake.yml
Outdated
Show resolved
Hide resolved
snaselj
reviewed
Sep 1, 2023
snaselj
reviewed
Sep 1, 2023
bryanculver
commented
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving these PRs over to this repo:
Please see if I botched a cherry-pick from that repo but hopefully after this we can sunset the other template in the other repo.