Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircuitMaintenance "name" should probably include provider as well as maintenance_id #75

Closed
glennmatthews opened this issue Aug 27, 2021 · 2 comments
Assignees
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: bug

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Nautobot version:
  • nautobot-circuit-maintenance version:

Proposed Functionality

As and when this plugin is used with an ever-growing set of providers sending maintenance notifications, it becomes increasingly likely that two different providers will send maintenance notifications that happen to use the same maintenance ID number/string. (Consider the case of two providers each sending their very first maintenance notification, and both choosing to identify it as maintenance id "00000001"). Because we use the maintenance_id as the globally-unique name of the CircuitMaintenance model instances, these two disparate sets of maintenance notifications would inadvertently be merged into a single CircuitMaintenance instance named 000000001, which is almost certainly undesirable.

To avoid collision between providers in this fashion, we should probably include the notification provider value in addition to the maintenance_id in constructing the CircuitMaintenance name.

Use Case

@chadell chadell added status: accepted This issue has been accepted by the maintainers team for implementation type: bug labels Aug 30, 2021
@chadell
Copy link
Contributor

chadell commented Aug 30, 2021

@glennmatthews +1

@chadell
Copy link
Contributor

chadell commented Sep 6, 2021

Addressed in #81

@chadell chadell closed this as completed Sep 6, 2021
itdependsnetworks pushed a commit to itdependsnetworks/nautobot-app-circuit-maintenance that referenced this issue Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted This issue has been accepted by the maintainers team for implementation type: bug
Projects
None yet
Development

No branches or pull requests

2 participants