2.0 #29

lampwins · 2022-11-05T04:18:05Z

Adds Required field rule type Mandatory Fields #15
Adds Unique field rule type Unique Fields #20
Adds Support for Jinja2 template context processing of regex rules Only apply regex rules based on other fields #28
Sets minimum nautobot version to 1.4.0 and migrates to modern core features.
Fixes API routes to be standardized (breaking change).

TODO:

~~Fix failing bulk edit tests for required and unique rules~~

lampwins · 2022-11-05T06:10:16Z

Sorry for the huge PR. This is a super low priority since I am out all week.

@glennmatthews @bryanculver I could use some help in figuring out why the bulk edit tests are failing for my two new models. Also would like to get this app updated to use the new CI pipeline features.

development/nautobot_config.py

README.md

docs/user/app_use_cases.md

...gine/templates/nautobot_data_validation_engine/regularexpressionvalidationrule_retrieve.html

...dation_engine/templates/nautobot_data_validation_engine/requiredvalidationrule_retrieve.html

...lidation_engine/templates/nautobot_data_validation_engine/uniquevalidationrule_retrieve.html

nautobot_data_validation_engine/tests/test_filters.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

snaselj · 2023-02-24T13:00:22Z

nautobot_data_validation_engine/custom_validators.py

+        # Required rules
+        for rule in RequiredValidationRule.objects.get_for_model(self.model):
+            field_value = getattr(obj, rule.field)
+            if field_value is None or field_value == "":


Is it possible to have a list [] in field_value?

- Removed all "rq" occurences - kept in `poetry.lock` Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>

* chore: Use NautobotFilterSet and bump nautobot 1.5 - Potentially we could use nautobot v1.4 with NautobotFilterSet, however, to be sure, it seems to be better to use v1.5 * fix: Nautobot version in tasks.py --------- Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>

* fix: remove .coverage * doc * fix: Missing logger name in nautobot config * doc: Update compatibility matrix - mark v2.0.0 to be compatible up to 1.99.99 * doc: Fix links to unique rules images * fix: Log error in case of jinja exception - `self.validation_error` raises an Exception and LOGGER would not be called this way * chore: Reformat lists - one item per line - to better recognize changes in reviews * cleanup: Unnecessary imports * fix: Text `required` used for `unique` validator objects * fix: Replace TestCase with NameSlugFilterTestCase * fix: Blacklisted fields validation typo --------- Co-authored-by: Jan Snasel <jan.snasel@networktocode.com> Co-authored-by: Steven <111259311+DistantVoyager@users.noreply.github.com>

chadell · 2023-04-03T05:24:50Z

@lampwins @DistantVoyager @snaselj is there anything missing in this PR?

snaselj · 2023-04-03T06:33:00Z

@lampwins @DistantVoyager @snaselj is there anything missing in this PR?

@chadell

LGTM from my perspective.

IMHO #44 should be merged to next as well before merging this one.

I'm preparing better system to align apps repositories with changes to nautobot-plugin cookiecutter template. It will be much easier then, to keep changes to template synced to baked cookies.

chadell · 2023-04-03T07:23:17Z

to clarify, there is no "official" next branch (it is actually this branch). so, are you proposing to merge #44 into this one, and them merge this to develop?

snaselj · 2023-04-03T07:40:07Z

to clarify, there is no "official" next branch (it is actually this branch). so, are you proposing to merge #44 into this one, and them merge this to develop?

You are right, the official 2.0 branch should be next-2.0. Not sure now, what is better, whether merge #44 => next first or merge this one first. What should be IMHO the final state is:

merged both 2.0 #29 and Updated plugin files and structure using cookiecutter template #44 to develop
removed next branch as it is just a feature branch

That will unblock cleanup and merge #30 and #34 to develop.

After that, this repo should be ready to create official next-2.0 branch, WDYT?

chadell · 2023-04-03T07:42:23Z

Yes, my idea was to merge this PR and #44 into develop, to release a new version of this plugin. (technically, it could be simply a minor update because I don't recall adding any breaking change).
Afterward, we could start working on adopting Nautobot 2.x

snaselj · 2023-04-03T07:48:53Z

Yes, my idea was to merge this PR and #44 into develop, to release a new version of this plugin. (technically, it could be simply a minor update because I don't recall adding any breaking change). Afterward, we could start working on adopting Nautobot 2.x

I'll cleanup and prepare for review #30 and #34 , after #29 and #44 gets merged.

* Used cookiecutter template to update tasks and dev * Updated root files to follow cookiecutter * Update docs to correspond to cookiecutter template * Modded pyproject.toml format to match cookiecutter * Updated github ci.yml using cookiecutter template * Minor fixes for black formatting * Removed unused imports for flake8 * Formatting fixes for pydocstyle D200, D202, D415 * Fixed pydocstyle docstring issues D101, D102, D106 * Removed tabs for black formatting * Updates to mkdocs and gitignore using cookiecutter * Updated .github dir using cookiecutter-ntc * Updated development dir using cookiecutter-ntc * Updated docs dir using cookiecutter-ntc * Updated inits using cookiecutter-ntc * Updated root source files using cookiecutter-ntc * Quick fixes for nautobot version * Use default ver in dockerfile; update nautobot min * Update poetry.lock * More changes to min nautobot 1.5.0 * Removed 1.4 from dockerfile nautobot ver * Bumped nautobot ver min to 1.5.2 for app rel v2.0 * Disabling some pylint checks to be addressed later * Handling for skipping a bugged view unit test * Minor formatting

DistantVoyager · 2023-04-03T14:03:55Z

PRs #29 and #44 have now been merged to develop. Are we ready to do the release for data validation v2.0.0 or @snaselj am I waiting until you submit #30 and #34?

snaselj · 2023-04-03T15:18:49Z

PRs #29 and #44 have now been merged to develop. Are we ready to do the release for data validation v2.0.0 or @snaselj am I waiting until you submit #30 and #34?

Hi @DistantVoyager, I just closed #30 and #34 as everything is included in this PR already 👍

lampwins added 3 commits November 5, 2022 00:15

initial work for 2.0

9d0a9d6

implements #28 - context aware regex rules

2a261c1

updated docs and release notes

557ffc1

lampwins marked this pull request as ready for review November 5, 2022 06:08

lampwins requested review from glennmatthews and chadell as code owners November 5, 2022 06:08

lampwins requested review from itdependsnetworks and bryanculver November 5, 2022 06:08

fix tests

f6c7baf

glennmatthews reviewed Nov 15, 2022

View reviewed changes

Apply suggestions from code review

5e6487a

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

bryanculver mentioned this pull request Dec 6, 2022

Enable Upstream Testing #30

Closed

glennmatthews mentioned this pull request Dec 20, 2022

Update __init__.py to better describe the app in the UI #32

Merged

bryanculver modified the milestone: Nautobot v2 Feb 16, 2023

snaselj self-assigned this Feb 23, 2023

snaselj reviewed Feb 24, 2023

View reviewed changes

This was referenced Feb 24, 2023

Simple fixes to next branch #38

Merged

fix: Better test empty field value #39

Closed

chore: Remove RQ (#37)

5737c3c

- Removed all "rq" occurences - kept in `poetry.lock` Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>

bryanculver assigned cmsirbu Mar 23, 2023

snaselj and others added 2 commits March 27, 2023 09:31

DistantVoyager requested a review from a team as a code owner March 27, 2023 15:26

This was linked to issues Mar 31, 2023

Mandatory Fields #15

Closed

Unique Fields #20

Closed

DistantVoyager approved these changes Apr 3, 2023

View reviewed changes

DistantVoyager added 2 commits April 3, 2023 09:29

Merge branch 'develop' into next

ceb49b6

Added newline for linting

8fb13c3

DistantVoyager merged commit b4c3bf7 into develop Apr 3, 2023
16 checks passed

DistantVoyager linked an issue Apr 3, 2023 that may be closed by this pull request

Only apply regex rules based on other fields #28

Closed

snaselj mentioned this pull request Apr 3, 2023

Changed extends 'base.html' to extends 'generic/object_detail.html' for detail templates #34

Closed

DistantVoyager mentioned this pull request Apr 6, 2023

Legacy templates need to extend generic/object_detail.html #33

Closed

DistantVoyager deleted the next branch April 28, 2023 13:19

pszulczewski mentioned this pull request May 10, 2023

Add plugins module. nautobot/nautobot-ansible#203

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.0 #29

2.0 #29

lampwins commented Nov 5, 2022 •

edited

lampwins commented Nov 5, 2022

snaselj Feb 24, 2023

chadell commented Apr 3, 2023

snaselj commented Apr 3, 2023 •

edited

chadell commented Apr 3, 2023

snaselj commented Apr 3, 2023 •

edited

chadell commented Apr 3, 2023

snaselj commented Apr 3, 2023

DistantVoyager commented Apr 3, 2023

snaselj commented Apr 3, 2023

2.0 #29

2.0 #29

Conversation

lampwins commented Nov 5, 2022 • edited

lampwins commented Nov 5, 2022

snaselj Feb 24, 2023

Choose a reason for hiding this comment

chadell commented Apr 3, 2023

snaselj commented Apr 3, 2023 • edited

chadell commented Apr 3, 2023

snaselj commented Apr 3, 2023 • edited

chadell commented Apr 3, 2023

snaselj commented Apr 3, 2023

DistantVoyager commented Apr 3, 2023

snaselj commented Apr 3, 2023

lampwins commented Nov 5, 2022 •

edited

snaselj commented Apr 3, 2023 •

edited

snaselj commented Apr 3, 2023 •

edited