Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only apply regex rules based on other fields #28

Closed
joewesch opened this issue Oct 21, 2022 · 0 comments · Fixed by #29
Closed

Only apply regex rules based on other fields #28

joewesch opened this issue Oct 21, 2022 · 0 comments · Fixed by #29

Comments

@joewesch
Copy link

Environment

  • Nautobot version:
  • nautobot-data-validation-engine version:

Proposed Functionality

Only apply a regex rule to a field when the value of another field meets a certain criteria.

Use Case

  • I want all device names in site ABC to start with ABC, and all device names in site DEF start with DEF.
  • I want all device names with a role of leaf to start with ABC, and all device names with a role of spine to start with DEF.
lampwins added a commit that referenced this issue Nov 5, 2022
@lampwins
implements #28 - context aware regex rules
2a261c1
@lampwins lampwins mentioned this issue Nov 5, 2022
Merged
DistantVoyager added a commit that referenced this issue Apr 3, 2023
@lampwins @glennmatthews
@snaselj @DistantVoyager
2.0 (#29)
b4c3bf7 
* initial work for 2.0

* implements #28 - context aware regex rules

* updated docs and release notes

* fix tests

* Apply suggestions from code review

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* chore: Remove RQ (#37)

- Removed all "rq" occurences
- kept in `poetry.lock`

Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>

* chore: Use NautobotFilterSet and bump nautobot 1.5 (#40)

* chore: Use NautobotFilterSet and bump nautobot 1.5

- Potentially we could use nautobot v1.4 with NautobotFilterSet,
  however, to be sure, it seems to be better to use v1.5

* fix: Nautobot version in tasks.py

---------

Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>

* Simple fixes to next branch (#38)

* fix: remove .coverage

* doc

* fix: Missing logger name in nautobot config

* doc: Update compatibility matrix

- mark v2.0.0 to be compatible up to 1.99.99

* doc: Fix links to unique rules images

* fix: Log error in case of jinja exception

- `self.validation_error` raises an Exception and LOGGER would not be
  called this way

* chore: Reformat lists - one item per line

- to better recognize changes in reviews

* cleanup: Unnecessary imports

* fix: Text `required` used for `unique` validator objects

* fix: Replace TestCase with NameSlugFilterTestCase

* fix: Blacklisted fields validation typo

---------

Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>
Co-authored-by: Steven <111259311+DistantVoyager@users.noreply.github.com>

* Updated plugin files and structure using cookiecutter template (#44)

* Used cookiecutter template to update tasks and dev

* Updated root files to follow cookiecutter

* Update docs to correspond to cookiecutter template

* Modded pyproject.toml format to match cookiecutter

* Updated github ci.yml using cookiecutter template

* Minor fixes for black formatting

* Removed unused imports for flake8

* Formatting fixes for pydocstyle D200, D202, D415

* Fixed pydocstyle docstring issues D101, D102, D106

* Removed tabs for black formatting

* Updates to mkdocs and gitignore using cookiecutter

* Updated .github dir using cookiecutter-ntc

* Updated development dir using cookiecutter-ntc

* Updated docs dir using cookiecutter-ntc

* Updated inits using cookiecutter-ntc

* Updated root source files using cookiecutter-ntc

* Quick fixes for nautobot version

* Use default ver in dockerfile; update nautobot min

* Update poetry.lock

* More changes to min nautobot 1.5.0

* Removed 1.4 from dockerfile nautobot ver

* Bumped nautobot ver min to 1.5.2 for app rel v2.0

* Disabling some pylint checks to be addressed later

* Handling for skipping a bugged view unit test

* Minor formatting

* Added newline for linting

---------

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Jan Snasel <snaselj@gmail.com>
Co-authored-by: Jan Snasel <jan.snasel@networktocode.com>
Co-authored-by: Steven <111259311+DistantVoyager@users.noreply.github.com>
@DistantVoyager DistantVoyager linked a pull request Apr 3, 2023 that will close this issue
2.0 #29
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.0 nautobot/nautobot-app-data-validation-engine
2 participants
@joewesch @DistantVoyager