Updates for Nautobot 2.0 #142

jdrew82 · 2023-06-21T15:17:57Z

This PR is focused on the updates required to support Nautobot 2.0. The changes involved include:

Updated all imports to be derived from new module locations.
Updated all models that no longer have slugs to use replacement field.
Updated navigation to use new NavMenu elements.
Updated metrics to use new Jobs model attributes.
Updated example Jobs to use new Location model instead of Region/Site along with updating IPAddress to specify parent Prefix.
Updated example Jobs to use new Job pattern with passed variables.
Updated Job loading to use new register_jobs function.
Updated logging in example Jobs to use new logger on JobResult.
Updated Infoblox integration to work with Nautobot 2.0.
Refactored Infoblox integration to have tags applied to imported objects after sync is complete.
Added pylint-nautobot to dev dependencies.
Addressed various linter complaints.
Corrected tests to address field and model changes.

Both example import Job and Infoblox -> Nautobot import Job are functional with test instances.

Addresses #148.

Starting update to support Nautobot 2.0 Now requires Nautobot 2.0 or better.

…odel

…nction was removed from core.

…ocationType of Region & Site Also updated to use new register_jobs pattern.

…as no longer needed.

…seJob

Also discovered issubclass to determine if Job is subclass of DataSource or DataTarget which is better than checking for SSoT in slug that no longer exists.

…s defined based on plugin config.

…levant any longer.

…d date_done var.

Updated Regions and Sites to use Locations and LocationTypes to match migrations. Same with Prefixs using Namespace for uniqueness instead of Tenant now. Also removed slug and used names for Status, Region, and Site. Logging has been updated to use JobResult object. Dry-run var is now using DryRunVar() for scheduling support. Updated everything to latest locations for Nautobot 2.0 so many many breaking changes.

… associated Job modules loaded.

As part of the changes removed Aggregate objects as that is no longer a valid model in 2.0. Updated all Site creation to be a Location. Also removed the associated setting for importing Aggregates. Updates for Nautobot 2.0 so lots of breaking changes. No longer an Aggregate object to import and removed extraneous Job. The `import_rfc1918" setting is no longer valid.

chadell

it looks go for me

.github/workflows/ci.yml

…ltering

…Nautobot 2.0 change.

…etwork status in Infoblox.

…not start until service_healthy.

jdrew82 · 2023-07-11T21:00:34Z

This should be ready for a re-review for beta 2. I fixed all the issues with Infoblox integration working with 2.0 and confirmed the example Job and the Infoblox import jobs work.

chadell

it still makes sense to me

pyproject.toml

Kircheneer · 2023-07-13T09:11:56Z

Very tiny nitpick, apart from that we're good

Kircheneer

LGTM

jdrew82 added 30 commits June 21, 2023 10:14

build: 💥 Start upgrade to Nautobot 2.0

2ec77c4

Starting update to support Nautobot 2.0 Now requires Nautobot 2.0 or better.

fix: 🚚 Updating imports for new locations in Nautobot 2.0

5ee82d7

fix: Temporarily disabled metrics until can be updated for new Jobs m…

fb82d13

…odel

fix: 💄 Fix the navigation elements to use new NavMenu elements

6dcb3bc

test: ✅ Temporarily skip test until can update for Nautobot 2.0 changes

6b21b4d

fix: Temporarily disable get_data_jobs functionality as get_jobs() fu…

86c14f2

…nction was removed from core.

refactor: ♻️ Update get_data_jobs() to work with new Job model directly

1b4090f

refactor: ♻️ Update Jobs to replace Region & Site with Location and L…

b93fb68

…ocationType of Region & Site Also updated to use new register_jobs pattern.

refactor: ♻️ Redo Job form to remove check for 1.2 and hiding commit …

1b6c60b

…as no longer needed.

refactor: ♻️ Update DataSyncBaseJob to inherit from Job instead of Ba…

743fdfe

…seJob

refactor: 🚚 Correct imports to use new locations

4e4628c

refactor: ♻️ Update metrics to use new Job model.

7ac2959

Also discovered issubclass to determine if Job is subclass of DataSource or DataTarget which is better than checking for SSoT in slug that no longer exists.

fix: 🐛 Add api kwarg to match super() function.

3d530d1

style: 🚚 Update var name to not conflict with jobs var.

a217fa2

refactor: 🚚 Move register_jobs method call to align with where jobs i…

3a4aa0b

…s defined based on plugin config.

docs: 📝 Updating documentation to remove atomic transaction as not re…

f4fd3f4

…levant any longer.

fix: 🐛 Correct duration function to use new JobResultStatusChoices an…

f2edd53

…d date_done var.

test: ✅ Update tests for new JobResult model attributes

24f265b

test: 🚨 Address various linter complaints

442ac6c

fix: 🐛 Correct View to perform Sync query with updated JobResult fields.

06e5dea

build: 🏗️ Add pylint-nautobot to dev-dependencies

e0a0c32

fix: 🐛 Correct Job init to address merge errors

d0cfebc

fix: 🐛 Fix JobResult status for Sync objects to fix dashboard view

496d57d

fix: 🐛 Update Sync query for data sources/targets to use class_path.

fbd1227

test: 🚨 Add timeouts to requests to address pylint complaint

5abe2fc

test: 🚨 Disable broad Exception linter complaint for adding integrations

3cb3169

test: 🚨 Remove unnecessary paranthesis for linter

6dbb05b

refactor: ♻️ Update Job registration to happen after integrations and…

fff00f8

… associated Job modules loaded.

chadell approved these changes Jul 10, 2023

View reviewed changes

glennmatthews reviewed Jul 10, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

jdrew82 added 15 commits July 11, 2023 09:35

build: ⬆️ Update to Nautobot 2.0.0b2

4f112f5

build: ⬆️ Update all project dependencies

3034b3b

fix: 🐛 Revert App to be in Plugins menu

add5a0c

fix: 🐛 Change Tags to use name and remove slug

6857a1f

test: ✅ Add ignored test for list_objects_unknown_filter_no_strict_fi…

d44fe5e

…ltering

ci: 👷 Update CI to use 2.0.0-beta2

11da154

ci: 👷 Update CI to use py 3.10 to match dev container

221802c

ci: 👷 Pylint should use 3.10 also

a99ea00

fix: 🐛 Update metric labels to use natural_key function

126ebb7

fix: 🐛 Correct other instances of Tag slug to name

263116c

refactor: ♻️ Change Prefix status attribute to network_type to match …

e25a929

…Nautobot 2.0 change.

refactor: ♻️ Made Status of Prefix Active always as can't determine n…

49aae0e

…etwork status in Infoblox.

fix: 🐛 Remove slug from VLANGroup creation.

da27a46

build: 🏗️ Add healthcheck to nautobot container and update worker to …

8ce83b5

…not start until service_healthy.

test: 🚨 Fix yamllint complaint

2663281

jdrew82 self-assigned this Jul 11, 2023

jdrew82 added type: major feature enhancement labels Jul 11, 2023

jdrew82 added this to the Nautobot v2 milestone Jul 11, 2023

chadell approved these changes Jul 12, 2023

View reviewed changes

Kircheneer reviewed Jul 13, 2023

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

build: 🔧 Remove 1.x from pylint-nautobot support versions

ddf1c67

Kircheneer approved these changes Jul 13, 2023

View reviewed changes

jdrew82 merged commit 28b0225 into next-2.0 Jul 13, 2023
11 checks passed

jdrew82 deleted the feat-2.0_update branch July 13, 2023 13:57

glennmatthews mentioned this pull request Jul 21, 2023

Migration Doc Revision: Getting a Nautobot App v2.0 Ready nautobot/nautobot#3387

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for Nautobot 2.0 #142

Updates for Nautobot 2.0 #142

jdrew82 commented Jun 21, 2023 •

edited

Loading

chadell left a comment

jdrew82 commented Jul 11, 2023

chadell left a comment

Kircheneer commented Jul 13, 2023

Kircheneer left a comment

Updates for Nautobot 2.0 #142

Updates for Nautobot 2.0 #142

Conversation

jdrew82 commented Jun 21, 2023 • edited Loading

chadell left a comment

Choose a reason for hiding this comment

jdrew82 commented Jul 11, 2023

chadell left a comment

Choose a reason for hiding this comment

Kircheneer commented Jul 13, 2023

Kircheneer left a comment

Choose a reason for hiding this comment

jdrew82 commented Jun 21, 2023 •

edited

Loading