Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JobResult page may fail to list JobLogEntries in chronological order #1193

Closed
glennmatthews opened this issue Dec 20, 2021 · 2 comments · Fixed by #1199
Closed

JobResult page may fail to list JobLogEntries in chronological order #1193

glennmatthews opened this issue Dec 20, 2021 · 2 comments · Fixed by #1199
Labels
type: bug Something isn't working as expected

Comments

@glennmatthews
Copy link
Contributor

Environment

  • Python version: 3.6
  • Nautobot version: 1.2.1

Steps to Reproduce

Unsure at this time

Expected Behavior

JobLogEntries to be listed in chronological order.

Observed Behavior

image

Looking at the code, either the JobLogEntry class should define a Meta.ordering property, or else the GitRepositoryResultView and JobResultView view should add an order_by() to their JobLogEntry querysets.
@glennmatthews glennmatthews added type: bug Something isn't working as expected group: automation labels Dec 20, 2021
@glennmatthews
Copy link
Contributor Author

Also, using settings.SHORT_DATETIME_FORMAT for this column is probably not ideal as it only gives minute-level precision. For most jobs, a HH:MM:SS.mmm display would probably be more useful.

@glennmatthews glennmatthews mentioned this issue Dec 21, 2021
Merged
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
Fixes #1193 - Set job logs datetime stamp in JobResult detail view to…
44741f3 
… be ISO standard.
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
Fixes #1193 - Set job log created date to use ISO format in JobResult…
f17b891 
… detail view.
@jathanism jathanism mentioned this issue Dec 21, 2021
Merged
@glennmatthews glennmatthews linked a pull request Dec 21, 2021 that will close this issue
Fixes #1193 - Set job log created date to use ISO format in JobResult detail view #1199
Merged
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
Fixes #1193 - Set job log created date to use ISO format in JobResult…
523b452 
… detail view (#1199)
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
[skip ci] Add release-notes for #1152, #1193
44b6a9e
@jathanism
Copy link
Contributor

Fixed in #1196 and #1199

jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
Fixes #1193 - Set job log created date to use ISO format in JobResult…
3312e2b 
… detail view (#1199)
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
[skip ci] Add release-notes for #1152, #1193
46aedca
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
Revert "[skip ci] Add release-notes for #1152, #1193"
0c78d05 
This reverts commit 44b6a9e.
jathanism added a commit that referenced this issue Dec 21, 2021
@jathanism
Revert "Fixes #1193 - Set job log created date to use ISO format in J…
160f7ad 
…obResult detail view (#1199)"

This reverts commit 523b452.
timizuoebideri1 pushed a commit that referenced this issue Feb 9, 2022
@jathanism @timizuoebideri1
[skip ci] Add release-notes for #1152, #1193
843a7d8
timizuoebideri1 pushed a commit that referenced this issue Feb 9, 2022
@jathanism @timizuoebideri1
Revert "[skip ci] Add release-notes for #1152, #1193"
8a3e2a0 
This reverts commit 44b6a9e.
timizuoebideri1 pushed a commit that referenced this issue Feb 9, 2022
@jathanism @timizuoebideri1
Revert "Fixes #1193 - Set job log created date to use ISO format in J…
5b20876 
…obResult detail view (#1199)"

This reverts commit 523b452.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug Something isn't working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1193 - Set job log created date to use ISO format in JobResult detail view nautobot/nautobot
2 participants
@jathanism @glennmatthews