Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1193 - Set job log created date to use ISO format in JobResult detail view #1199

Merged
merged 3 commits into from Dec 21, 2021

Conversation

jathanism
Copy link
Contributor

@jathanism jathanism commented Dec 21, 2021

Fixes: #1193

Set job log created date to use ISO format in JobResult detail view.

Cursor_and_Notification_Center

@glennmatthews
Copy link
Contributor

Personally I feel like this is maybe overkill - given the vast majority of Jobs should run to completion in a matter of minutes, the YY-MM-DD and timezone portions of the output are mostly noise. What do you think of just setting it to display HH:MM:SS.ssssss instead? We have the JobResult detail at the top of the page showing the overall date and time of the job, after all.

@jathanism
Copy link
Contributor Author

Personally I feel like this is maybe overkill - given the vast majority of Jobs should run to completion in a matter of minutes, the YY-MM-DD and timezone portions of the output are mostly noise. What do you think of just setting it to display HH:MM:SS.ssssss instead? We have the JobResult detail at the top of the page showing the overall date and time of the job, after all.

What you're proposing is H:i:s.u:

image

I'm thinking split the difference to include the Y-m-d but without the timezone information? Specifically that would be Y-m-d H:i:s.u:
image

@glennmatthews
Copy link
Contributor

Splitting the difference is OK with me.

@jathanism jathanism merged commit 523b452 into next Dec 21, 2021
@jathanism jathanism deleted the jathanism-joblog-date-format branch December 21, 2021 20:34
jathanism added a commit that referenced this pull request Dec 21, 2021
jathanism added a commit that referenced this pull request Dec 21, 2021
timizuoebideri1 pushed a commit that referenced this pull request Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JobResult page may fail to list JobLogEntries in chronological order
2 participants