-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Custom Field Name Changes #137
Comments
Yeah I would definitely lean towards a custom field not being able to be renamed once it is created. That would go a long way to avoiding an issue like this entirely that results in apparent data loss. Other concrete model fields cannot be renamed, so I think this asserts that consistency and prevents us from having to come up with an over-engineered solution. |
What about adding |
Custom fields actually do already have a |
@itdependsnetworks can you test again using labels? Does that help? If so, this could be added to the docs in the short term. |
actually, I am incorrect, I was referring to #135 yes, I think documentation for now is the course of action, with a longer term solution. |
For now, we will not allow the name or type to be changed once created. |
* fixes #135, #136, and #201 - custom fields choices refactor * pr feedback * pr feedback * refactor migrations (again) and rename custom_field_data to _custom_field_data to make it private * pr feedback and added webhooks queue * updated docs * Update nautobot/docs/additional-features/custom-fields.md Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Environment
Steps to Reproduce
color
on the dcim.device modelred
colour
color
Expected Behavior
Either custom fields should not be editable or when edited, the data should migrate as well.
Observed Behavior
The data seems to "disappear" on the UI. When the custom field name is returned, the data "reappears".
Screenshots
The text was updated successfully, but these errors were encountered: