Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blank margin around footer on Device pages #1408

Closed
u1735067 opened this issue Feb 23, 2022 · 1 comment · Fixed by #1550
Closed

Blank margin around footer on Device pages #1408

u1735067 opened this issue Feb 23, 2022 · 1 comment · Fixed by #1550
Assignees
@timizuoebideri1
Labels
type: bug Something isn't working as expected

Comments

@u1735067
Copy link
Contributor

Environment

  • Python version: 3.10
  • Nautobot version: 1.2.7

Steps to Reproduce

  1. Navigate to Device, Device tab or Advanced tab, like https://demo.nautobot.com/dcim/devices/a2d59253-d911-4f54-bc3e-b387adc44fd2/
  2. Scroll to bottom

Expected Behavior

There's no space between the footer and the browser border

Observed Behavior

There's no space between the footer and the browser border

Additional informations

The footer is included in the .wrapper div in those pages, instead of being in the body tag; maybe something in https://github.com/nautobot/nautobot/blob/v1.2.7/nautobot/dcim/templates/dcim/device.html ?
@glennmatthews glennmatthews added group: ui-ux type: bug Something isn't working as expected labels Feb 23, 2022
@glennmatthews
Copy link
Contributor

Thanks for the report!

@lampwins lampwins added this to the v1.3.0 milestone Mar 7, 2022
@bryanculver bryanculver removed this from the v1.3.0 milestone Mar 7, 2022
@timizuoebideri1 timizuoebideri1 mentioned this issue Mar 25, 2022
Merged
6 tasks
@timizuoebideri1 timizuoebideri1 self-assigned this Mar 25, 2022
glennmatthews added a commit that referenced this issue Mar 25, 2022
@glennmatthews
Add release-notes for #1408, #1467, #1529
e959cb2
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timizuoebideri1 timizuoebideri1

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove blank margin around device footer nautobot/nautobot
5 participants
@bryanculver @lampwins @u1735067 @glennmatthews @timizuoebideri1