Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secret Assignment "Add another Secret" css invalid #1710

Closed
jifox opened this issue Apr 28, 2022 · 3 comments · Fixed by #1785
Closed

Secret Assignment "Add another Secret" css invalid #1710

jifox opened this issue Apr 28, 2022 · 3 comments · Fixed by #1785
Assignees
@jathanism
Labels
type: bug Something isn't working as expected
Milestone
v1.4.0

Comments

@jifox
Copy link
Contributor

jifox commented Apr 28, 2022

Environment

  • Python version: 3.9
  • Nautobot version: 1.3.2

Steps to Reproduce

  1. Edit "Secrets Group"
  2. Click on button "Add another Secret"

Expected Behavior

Line should be formatted same as all lines above

Observed Behavior

Line is not formatted correct

image
@bryanculver bryanculver added type: bug Something isn't working as expected group: ui-ux labels Apr 28, 2022
@jathanism jathanism self-assigned this Jun 3, 2022
@jathanism jathanism added this to the v1.4.0 milestone Jun 3, 2022
@jathanism
Copy link
Contributor

This issue also exists in Custom Field Choice UI (#997), and in the MVP for Dynamic Groups of Dynamic Groups (#1785),

@jathanism
Copy link
Contributor

We will likely need to patch nautobot/project-static/jquery/jquery.formset.js in some way to account for the proper CSS/attribute values needed to make the style consistent.

@bryanculver bryanculver linked a pull request Jun 14, 2022 that will close this issue
[MVP] Dynamic Groups of Groups #1785
Merged
6 tasks
@bryanculver
Copy link
Member

Code complete. Being brought in via #1785 (#1614)

This was referenced Jul 15, 2022
Merged
Closed
jathanism added a commit that referenced this issue Jul 19, 2022
@jathanism
Added release-notes for #1614, #1710, and #2061
8958bc3
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jathanism jathanism

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

[MVP] Dynamic Groups of Groups nautobot/nautobot
3 participants
@bryanculver @jathanism @jifox