Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Group of Groups: Add draggable child groups, recompute and hide weight. #2061

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

bryanculver
Copy link
Member

@bryanculver bryanculver commented Jul 15, 2022

Closes: #DNE

What's Changed

  • Add dragging and re-weighting to Dynamic Group of Groups memberships

Drag to Re-Weight

Screen.Recording.2022-07-15.at.01.54.04.mov

Ignores Empty Rows

Screen.Recording.2022-07-15.at.02.03.04.mov

**

TODO

  • Explanation of Change(s)
  • Attached Screenshots, Payload Example
  • NA Unit, Integration Tests
  • NA Documentation Updates (when adding/changing features)
  • NA Example Plugin Updates (when adding/changing features)
  • NA Outline Remaining Work, Constraints from Design

@bryanculver bryanculver changed the title Add draggable child groups, recompute and hide weight. Dynamic Group of Groups: Add draggable child groups, recompute and hide weight. Jul 15, 2022
@bryanculver bryanculver mentioned this pull request Jul 15, 2022
6 tasks
@jathanism jathanism changed the base branch from jathanism-dynamic-groups-of-groups-1614 to next July 15, 2022 08:54
@bryanculver
Copy link
Member Author

Screenshot above still had some cache from #1710. Re-recorded:

Screen.Recording.2022-07-15.at.05.10.56-short.mov

Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nits but I'm loving this. Thank you!

nautobot/extras/templates/extras/dynamicgroup_edit.html Outdated Show resolved Hide resolved
nautobot/extras/templates/extras/dynamicgroup_edit.html Outdated Show resolved Hide resolved
nautobot/extras/templates/extras/dynamicgroup_edit.html Outdated Show resolved Hide resolved
@jathanism jathanism merged commit fc9b149 into next Jul 19, 2022
@jathanism jathanism deleted the bsc-dygog-draggable-members branch July 19, 2022 13:28
jathanism added a commit that referenced this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants