Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relationships edit page incorrectly states source/destination filters are Queryset filters instead of Filterset filters #1795

Closed
jcsicard opened this issue May 19, 2022 · 1 comment · Fixed by #2031
Assignees
Labels
type: bug Something isn't working as expected

Comments

@jcsicard
Copy link

Environment

  • Python version: n/a
  • Nautobot version: 1.3.3

Steps to Reproduce

  1. Browse to https://nautobot/extras/relationships/add/
  2. Create a new relationship with a source type "dcim | interface"
  3. Enter a source filter with related objects filters such as {"device__site__name__in": ["HQ"]} )
  4. Click create

Expected Behavior

Since information text below "Source filter" and "Destination filter" textboxes state "Queryset filter matching the applicable source objects of the selected type. Enter in JSON format.", expected Queryset filter to be accepted

Observed Behavior

Results in an error
'device__site__name__in' is not a valid filter parameter for dcim.Interface object

Per @glennmatthews, relationships source/destination filters are actually Filterset filters rather than Queryset filters.
Info text should be modified to reflect that.

@glennmatthews glennmatthews added type: bug Something isn't working as expected group: ui-ux labels May 20, 2022
@bryanculver
Copy link
Member

Would be good to make this explicit in the documentation as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't working as expected
Projects
No open projects
Archived in project
4 participants