Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker containers should not include a poetry cache #2342

Closed
gsnider2195 opened this issue Aug 30, 2022 · 2 comments · Fixed by #2349
Closed

Docker containers should not include a poetry cache #2342

gsnider2195 opened this issue Aug 30, 2022 · 2 comments · Fixed by #2349
Assignees
@glennmatthews
Labels
type: housekeeping Changes to the application which do not directly impact the end user

Comments

@gsnider2195
Copy link
Contributor

Proposed Changes

Run poetry cache clear -n --all pypi in the final step of the Dockerfile

Justification

Reduce file size of docker container by removing cached wheel files that are no longer needed
@lampwins lampwins added the type: housekeeping Changes to the application which do not directly impact the end user label Aug 30, 2022
@glennmatthews glennmatthews self-assigned this Aug 31, 2022
@glennmatthews
Copy link
Contributor

glennmatthews commented Aug 31, 2022 •
edited
Loading

Appears to be currently blocked by python-poetry/cleo#234; should be fixed in the next release of cleo whenever that happens and Poetry is updated to make use of it.

Actually, maybe also python-poetry/poetry#4998

@glennmatthews
Copy link
Contributor

glennmatthews commented Aug 31, 2022 •
edited
Loading

Should only be an issue with the final-dev development image, as the final image doesn't include poetry at all.

glennmatthews added a commit that referenced this issue Aug 31, 2022
@glennmatthews
Fix #2342, and updates for Poetry 1.2
325d9e3
@glennmatthews glennmatthews mentioned this issue Aug 31, 2022
Merged
glennmatthews added a commit that referenced this issue Sep 2, 2022
@glennmatthews
Fix #2342, and updates for Poetry 1.2 (#2349)
834fe95 
* Fix #2342, and updates for Poetry 1.2

* Ignore overly-zealous hadolint 'set -o pipefail' rule

* Pin poetry version
glennmatthews added a commit that referenced this issue Sep 2, 2022
@glennmatthews
Add release-notes for #2307,#2342,#2347,#2349,#2350,#2360
3f72e5c
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2342, and updates for Poetry 1.2 nautobot/nautobot
3 participants
@lampwins @glennmatthews @gsnider2195