Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RQ entirely #2523

Closed
glennmatthews opened this issue Sep 28, 2022 · 2 comments · Fixed by #3039
Closed

Remove RQ entirely #2523

glennmatthews opened this issue Sep 28, 2022 · 2 comments · Fixed by #3039
Assignees
@glennmatthews
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@glennmatthews
Copy link
Contributor

Proposed Changes

Remove dependency on django-rq, remove all code that depends on it, clean up the documentation, etc.

Justification

Not actively used in Nautobot core since 1.1.0.
@glennmatthews glennmatthews added type: housekeeping Changes to the application which do not directly impact the end user impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release labels Sep 28, 2022
@bryanculver bryanculver added this to the v2.0.0 milestone Nov 3, 2022
@glennmatthews glennmatthews mentioned this issue Nov 16, 2022
Closed
@jathanism
Copy link
Contributor

jathanism commented Nov 16, 2022 •
edited

2.0 TODO Items

nautobot/core/api/views.py
- # 2.0 TODO: remove rq-workers-running property
- # 2.0 TODO: remove rq-workers-running

nautobot/utilities/exceptions.py
- # 2.0 TODO remove this in 2.0

@glennmatthews glennmatthews self-assigned this Dec 21, 2022
glennmatthews added a commit that referenced this issue Dec 21, 2022
@glennmatthews
Remove django-rq. Fixes #2523
38862d5
glennmatthews added a commit that referenced this issue Dec 21, 2022
@glennmatthews
Remove django-rq. Fixes #2523
9988a63
@glennmatthews glennmatthews mentioned this issue Dec 21, 2022
Merged
4 tasks
@glennmatthews glennmatthews linked a pull request Dec 21, 2022 that will close this issue
Remove django-rq #3039
Merged
4 tasks
glennmatthews added a commit that referenced this issue Jan 5, 2023
@glennmatthews
Remove django-rq (#3039)
f85d1db 
* Remove django-rq. Fixes #2523

* Update architecture diagrams to remove RQ

* Address review feedback
@glennmatthews
Copy link
Contributor Author

Resolved in #3039 for 2.0.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Remove django-rq nautobot/nautobot
3 participants
@bryanculver @jathanism @glennmatthews