Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove drf-yasg dependency #2524

Closed
glennmatthews opened this issue Sep 28, 2022 · 1 comment · Fixed by #3304
Closed

Remove drf-yasg dependency #2524

glennmatthews opened this issue Sep 28, 2022 · 1 comment · Fixed by #3304
Assignees
@glennmatthews
Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Milestone
v2.0.0

Comments

@glennmatthews
Copy link
Contributor

Proposed Changes

Remove packaging dependency on drf-yasg. It's unused in core since 1.3 but we kept it to avoid immediately breaking any plugins that had this as an implicit dependency.

Justification

Dependency cleanup.
@glennmatthews glennmatthews added type: housekeeping Changes to the application which do not directly impact the end user impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release labels Sep 28, 2022
@bryanculver bryanculver added this to the v2.0.0 milestone Nov 3, 2022
@glennmatthews glennmatthews self-assigned this Feb 13, 2023
glennmatthews added a commit that referenced this issue Feb 13, 2023
@glennmatthews
Fix #2524 - remove drf-yasg
a33d72e
@glennmatthews glennmatthews mentioned this issue Feb 13, 2023
Merged
2 tasks
@glennmatthews glennmatthews linked a pull request Feb 13, 2023 that will close this issue
Remove drf-yasg #3304
Merged
2 tasks
glennmatthews added a commit that referenced this issue Feb 13, 2023
@glennmatthews
Fix #2524 - remove drf-yasg (#3304)
66f68ea
@bryanculver
Copy link
Member

Closed via #3304

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@glennmatthews glennmatthews

Labels
impact: breaking change This change or feature will remove or replace existing functionality; needs to be an X.0.0 release type: housekeeping Changes to the application which do not directly impact the end user
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Remove drf-yasg nautobot/nautobot
2 participants
@bryanculver @glennmatthews