Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Search Fields in Advanced Filter Form #3018

Closed
bryanculver opened this issue Dec 17, 2022 · 0 comments · Fixed by #3019
Closed

Cannot Search Fields in Advanced Filter Form #3018

bryanculver opened this issue Dec 17, 2022 · 0 comments · Fixed by #3019
Assignees
@bryanculver
Labels
type: bug Something isn't working as expected

Comments

@bryanculver
Copy link
Member

Environment

  • Nautobot version (Docker tag too if applicable): 1.5+
  • Python version: 3.7+
  • Database platform, version: NA
  • Middleware(s): Na

Steps to Reproduce

  1. Click the "Filter" button on any list view
  2. Click the "Advanced" tab
  3. Click a field dropdown
  4. Try typing in the search box

Expected Behavior

I can filter down the fields to filter on.

Observed Behavior

Typing does nothing.

Demo:

Untitled.mov

This is due to a Select2 & Bootstrap modal issue. Certain Select2 fields hidden in modals lose certain functionality (top "Common Problem" of Select2):
bryanculver added a commit that referenced this issue Dec 17, 2022
@bryanculver
Fix #3018: Update Select2 widgets to know they are in a modal.
e3d80a3 
- Add `dropdownParent` argument to Select2 initializers (defaults to null for legacy calls)
- Loop over modals to reinitialize their Select2 widgets to update the dropdownParent property
bryanculver added a commit that referenced this issue Dec 17, 2022
@bryanculver
Fix #3018: Update Select2 widgets to know they are in a modal.
5a36351 
- Add `dropdownParent` argument to Select2 initializers (defaults to null for legacy calls)
- Loop over modals to reinitialize their Select2 widgets to update the dropdownParent property
@bryanculver bryanculver mentioned this issue Dec 17, 2022
Merged
5 tasks
@bryanculver bryanculver added the type: bug Something isn't working as expected label Dec 19, 2022
glennmatthews added a commit that referenced this issue Dec 22, 2022
@bryanculver @glennmatthews
Update Select2 Widgets to Know if They Are in a Modal (#3019)
94fffd8 
* Fix #3018: Update Select2 widgets to know they are in a modal.

- Add `dropdownParent` argument to Select2 initializers (defaults to null for legacy calls)
- Loop over modals to reinitialize their Select2 widgets to update the dropdownParent property

* Update changes/3018.fixed

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

* Feedback

* Forgot the modal bit

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@bryanculver bryanculver mentioned this issue Jan 9, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bryanculver bryanculver

Labels
type: bug Something isn't working as expected
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Select2 Widgets to Know if They Are in a Modal nautobot/nautobot
1 participant
@bryanculver