Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golden Configuration Plugin referenced from docs but missing from github #42

Closed
falz opened this issue Feb 26, 2021 · 2 comments · Fixed by #54
Closed

Golden Configuration Plugin referenced from docs but missing from github #42

falz opened this issue Feb 26, 2021 · 2 comments · Fixed by #54
Assignees
@itdependsnetworks
Labels
type: documentation Improvements or additions to documentation
Milestone
v1.0.0

Comments

@falz
Copy link

falz commented Feb 26, 2021

Change Type

[ ] Addition
[X ] Correction
[ ] Deprecation
[ ] Cleanup (formatting, typos, etc.)

Area

[ X] Installation instructions
[ ] Configuration parameters
[ X] Functionality/features
[ ] REST API
[ ] Administration/development
[ ] Other

Proposed Changes

On the readthedocs page, there's a reference to Golden Configuration plugin:

.. which links to a missing project on github:

Should this exist? Is it locked down? Is this plug-in commercial?
@itdependsnetworks
Copy link
Contributor

Apologies, this is on me. Looking to address this tonight. You can pip install it, but the instructions are not there yet to reasonably install it.

@jathanism jathanism added the type: documentation Improvements or additions to documentation label Feb 26, 2021
@jathanism jathanism added this to the v1.0.0 milestone Feb 26, 2021
@itdependsnetworks itdependsnetworks mentioned this issue Feb 27, 2021
Merged
@itdependsnetworks
Copy link
Contributor

@falz wrong link, plus not public. I have now made it public, and you can reach it at https://github.com/nautobot/nautobot-plugin-golden-config

I have also put in a PR to resolve the issues.

andy-wm-arthur pushed a commit to dolthub/nautobot that referenced this issue Mar 2, 2021
@jathanism @glennmatthews
Fix nautobot#42 - Disable external auth backends by default; replace …
a061837 
…them w/ guides

- The built-in authentication backends (`netbox.authentication.RemoteUserBackend` and `netbox.authentication.LDAPBackend`) have been removed from `AUTHENTICATION_BACKENDS` in `netbox/netbox/settings.py`
- Original LDAP install guide replaced with External Authentication guide
- LDAP guide moved from installation to configuration section
  - References to `ldap_config.py` have been removed but it is still supported if using the deprecated `netbox.authenticatoin.LDAPBackend`
  - References to using `netbox.authentication.LDAPBackend` removed but is still supported
- A newly created remote user auth guide has been added in configuration section
  - Docs for ` REMOTE_AUTH*` config settings for remote auth moved to remote user guide
- The configuration setting `REMOTE_AUTH_ENABLED` now defaults to `True` so that if it is deliberately configured by end-users, it will work without any confusion. This was also left for backwards compatibility for the interim.
- The unit tests for authentication have been modified slightly to adjust the updated configuration settings.
andy-wm-arthur pushed a commit to dolthub/nautobot that referenced this issue Mar 2, 2021
@jathanism @glennmatthews
Merge pull request nautobot#43 from networktocode-llc/jathanism-disab…
4100e19 
…le-auth-backends

Fix nautobot#42 - Disable external auth backends by default
andy-wm-arthur pushed a commit to dolthub/nautobot that referenced this issue Mar 2, 2021
@jathanism @dgarros
Fix nautobot#42 - Disable external auth backends by default; replace …
e6d76c9 
…them w/ guides

- The built-in authentication backends (`netbox.authentication.RemoteUserBackend` and `netbox.authentication.LDAPBackend`) have been removed from `AUTHENTICATION_BACKENDS` in `netbox/netbox/settings.py`
- Original LDAP install guide replaced with External Authentication guide
- LDAP guide moved from installation to configuration section
  - References to `ldap_config.py` have been removed but it is still supported if using the deprecated `netbox.authenticatoin.LDAPBackend`
  - References to using `netbox.authentication.LDAPBackend` removed but is still supported
- A newly created remote user auth guide has been added in configuration section
  - Docs for ` REMOTE_AUTH*` config settings for remote auth moved to remote user guide
- The configuration setting `REMOTE_AUTH_ENABLED` now defaults to `True` so that if it is deliberately configured by end-users, it will work without any confusion. This was also left for backwards compatibility for the interim.
- The unit tests for authentication have been modified slightly to adjust the updated configuration settings.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@itdependsnetworks itdependsnetworks

Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Update Golden Config Link itdependsnetworks/nautobot
3 participants
@jathanism @falz @itdependsnetworks