Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document custom relationships feature #47

Closed
2 tasks
jathanism opened this issue Feb 26, 2021 · 2 comments · Fixed by #56
Closed
2 tasks

Document custom relationships feature #47

jathanism opened this issue Feb 26, 2021 · 2 comments · Fixed by #56
Labels
type: documentation Improvements or additions to documentation
Milestone

Comments

@jathanism
Copy link
Contributor

jathanism commented Feb 26, 2021

Change Type

[x] Addition
[ ] Correction
[ ] Deprecation
[ ] Cleanup (formatting, typos, etc.)

Area

[ ] Installation instructions
[x] Configuration parameters
[x] Functionality/features
[x] REST API
[x] Administration/development
[ ] Other

Proposed Changes

The new custom relationships feature is not yet tested or documented. This should track the work for documentation.

The way I see it, this is an advanced feature and the documentation for it needs to be verbose, and would be better with screenshots and examples. For example, the source/destination filters are easy to get wrong, and after defining them, how should they be tested to make sure they work as intended? I think the Device to VLANs example we've been using to describe this would be perfect use-case for how to implement and expand the documentation.

Documentation should include

  • User guide
  • Developer guide
@jathanism jathanism added type: documentation Improvements or additions to documentation status: current labels Feb 26, 2021
@jathanism jathanism added this to the v1.0.0 milestone Feb 26, 2021
@glennmatthews
Copy link
Contributor

Reopening this as incomplete per Jathan's comment on #56:

This is a great start to documenting this, and I'm happy to merge this as-is, but IMO this is not verbose enough and would be better with screenshots and examples. This is a pretty advanced feature, and the source/destination filters are easy to get wrong. I think the Device to VLANs example we've been using to describe this would be perfect use-case for how to implement and expand the documentation.

@glennmatthews glennmatthews reopened this Mar 2, 2021
andy-wm-arthur pushed a commit to dolthub/nautobot that referenced this issue Mar 2, 2021
…igration-fix

Fix incorrect custom-job migration logic
@glennmatthews
Copy link
Contributor

Re-closing this - additional documentation for this feature will be handled under #86.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants