Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Data Model Changes" section to "Migrating from NetBox" #121

Merged
merged 4 commits into from
Mar 10, 2021

Conversation

jathanism
Copy link
Contributor

@jathanism jathanism commented Mar 9, 2021

  • Explaining difference in importing objects with a status field
  • Explaining difference ID fields as UUIDs and no longer integers

Related to: #62

- Explaining difference in importing objects with a `status` field
@jathanism jathanism requested a review from dgarros March 9, 2021 15:37
nautobot/docs/models/extras/status.md Outdated Show resolved Hide resolved

## Data Model Changes

The following backwards-incompatible changes have been made to the data model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's our plan to move forward with this section? Will this become an ever-growing list of changes as we diverge further from NetBox? Are we adding content here that's better suited to the Release Notes and/or the per-model documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking it would be good to have them tracked here centrally, as the release notes start to fade into history.

We might need to decide for how long we intend to maintain this guide. As I see it, it's a "for now", and not a "forever".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add a note about the primary key int/UUID change as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what. I was going to do that but decided to leave it for another PR.

Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @jathanism


## Data Model Changes

The following backwards-incompatible changes have been made to the data model.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to add a note about the primary key int/UUID change as well?

@jathanism
Copy link
Contributor Author

@glennmatthews I went ahead and added a note about UUID fields. 📦

@jathanism jathanism merged commit 4e9c8b1 into nautobot:develop Mar 10, 2021
@jathanism jathanism deleted the jathanism-status-migrate branch March 10, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants