JSON Array Field #131
Merged
JSON Array Field #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathanism
suggested changes
Mar 11, 2021
andy-wm-arthur
force-pushed
the
andy/json-array
branch
from
a041f0f
to
d912404
Compare
jathanism
approved these changes
Mar 19, 2021
andy-wm-arthur
force-pushed
the
andy/json-array
branch
from
a1f2f88
to
dca3f31
Compare
jathanism
approved these changes
Mar 24, 2021
nautobot/utilities/forms/fields.py
Outdated
| """ | ||
| A FormField counterpart to JSONArrayField. | ||
| Replicates ArrayFormField's base field validation: Field values are validated as JSON Arrays, | ||
| and each Array element is validated by |base_field| validators. |
There was a problem hiding this comment.
If you could sub the |foo| pipes w/ backticks here in this class, too, please.
glennmatthews
approved these changes
Mar 24, 2021
| @@ -45,6 +45,9 @@ def setUpTestData(cls): | |||
| cls.status = cls.statuses.get(slug="connected") | |||
| cls.status_planned = cls.statuses.get(slug="planned") | |||
|
|
|||
| # create a Cable that is not contained in any CablePath | |||
| cls.dneCable = Cable(status=cls.status) | |||
There was a problem hiding this comment.
is this being created intentionally as an invalid object? Normally the Cable terminations are required to be non-null and are checked for validity in the Cable.clean() method.
There was a problem hiding this comment.
Yes, it's the "does not exist cable". It's used in assertContainedByPath() to assert that path_contains is not returning false positives. Attempting to .clean() or .save() this Cable will fail, but it's valid to use it in filter expressions
jathanism
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces uses of Postgres array fields with a custom JSON array field