Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect settings.PAGINATE_COUNT in default REST API pagination (#1329) #1332

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

glennmatthews
Copy link
Contributor

Relates-to #1329

#1079 inadvertently changed the default behavior of the REST API when listing objects to be non-paginated (listing all objects) instead of the former behavior of defaulting to paginating with a limit of settings.PAGINATE_COUNT. This PR restores the original behavior, and adds test coverage.

Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hero is you.

nautobot/core/tests/test_api.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants