Correct permissions for scheduled-job REST APIs #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanculver
approved these changes
Mar 17, 2022
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
|
TODO:
|
jathanism
approved these changes
Mar 18, 2022
This was referenced Mar 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1478
Correct the permissions on our custom scheduledjob REST API endpoints:
/api/extras/scheduled-jobs/<pk>/approve/extras.add_scheduledjobpermissionextras.change_scheduledjobpermissionextras.approve_jobpermission/api/extras/scheduled-jobs/<pk>/deny/extras.add_scheduledjobpermissionextras.delete_scheduledjobpermissionextras.approve_jobpermission/api/extras/scheduled-jobs/<pk>/dry-run/extras.add_scheduledjobpermissionextras.view_scheduledjobpermissionextras.run_jobpermissionThere's got to be a better/cleaner way to adjust the permissions enforced for a given viewpoint that wouldn't require both overriding
ModelViewSetMixin.restrict_querysetand subclassingTokenPermissions, but this is the briefest approach I've been able to identify with respect to the current implementation in Nautobot.