-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked possible index opportunities so far #1793
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback left:
👍 - Good index to add (a few are suggested as an index_together)
😕 - Index candidate need a possible performance eval. Leave TODO for future review.
👎 - Index isn't needed at this time (non-obvious value or may not improve performance)
@briddo Can you update this to target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please target next
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for CI then will merge.
Related To #1639
Marking out possible index opportunities for discussion
Fields to be indexed are marked with
# todoindex:
in the diffs.Fields where we'll need to profile use cases are marked with
# TODO: Profile filtering on this field if it could benefit from an index
in the diffsTODO