New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marked possible index opportunities so far #1793

Merged

bryanculver merged 13 commits into next from dpb-spike-1639

Jun 8, 2022

Contributor

briddo commented May 19, 2022 •

edited

Loading

Related To #1639

Marking out possible index opportunities for discussion

Fields to be indexed are marked with # todoindex: in the diffs.
Fields where we'll need to profile use cases are marked with # TODO: Profile filtering on this field if it could benefit from an index in the diffs

TODO

Put code references in diffs

briddo added 4 commits

May 19, 2022 16:50


          Marked possible index opportunities so far

a67671f


          Added more opportunities for indexing (more to come!)

fdc6d85


          Added more opportunities for indexing (more to come!)

862181d


          Finished investigation. All potential indexes marked with # todoindex:

023ba91

glennmatthews reviewed

View reviewed changes

Contributor

glennmatthews left a comment

Good stuff!

nautobot/extras/models/datasources.py Outdated Show resolved Hide resolved

nautobot/dcim/models/sites.py Outdated Show resolved Hide resolved


          Removed AutoSlugFields from potential indexes

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/circuits/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/cables.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/device_components.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/device_components.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/dcim/models/power.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/change_logging.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/customfields.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/customfields.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/customfields.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/jobs.py Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/jobs.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/models.py Outdated Show resolved Hide resolved

briddo commented

View reviewed changes

nautobot/extras/models/models.py Outdated Show resolved Hide resolved


          Removed potential index comments as discussed

2d72979

bryanculver reviewed

View reviewed changes

Member

bryanculver left a comment

Feedback left:

👍 - Good index to add (a few are suggested as an index_together)
😕 - Index candidate need a possible performance eval. Leave TODO for future review.
👎 - Index isn't needed at this time (non-obvious value or may not improve performance)

briddo and others added 5 commits

June 1, 2022 13:13


          Merge branch 'develop' into dpb-spike-1639

6f41fbc


          Removed unneeded toindex comments (as discussed)

64cf61a


          Added Meta.indexes and Meta.constraints as discussed

955fefc


          Finished up marking certain field as needs profiling and added new co…

1242b29

…nstraint and migration as discussed


          black

8d863b2

briddo marked this pull request as ready for review

June 1, 2022 14:24

glennmatthews approved these changes

View reviewed changes

briddo requested review from bryanculver and glennmatthews

June 1, 2022 14:24

Member

bryanculver commented Jun 2, 2022

@briddo Can you update this to target next? It's for the 1.4 milestone.

bryanculver requested changes

View reviewed changes

Member

bryanculver left a comment

Please target next.

briddo changed the base branch from develop to next

June 3, 2022 11:35

briddo requested a review from bryanculver

June 3, 2022 11:36


          Merge branch 'next' into dpb-spike-1639

9a19a23

bryanculver approved these changes

View reviewed changes

Member

bryanculver left a comment

Waiting for CI then will merge.

bryanculver merged commit f0c111b into next

bryanculver added a commit that referenced this pull request


          Add release-note for #1793

aa5cd1b

bryanculver mentioned this pull request

Spike: Identify opportunities to introduce proper indexing on model fields #1639

Closed

bryanculver deleted the dpb-spike-1639 branch

July 7, 2022 15:49

bryanculver mentioned this pull request

Profile highly-used model fields to see if they should have indexes added. #2780

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment