Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom interval to scheduled job view #2143

Merged
merged 49 commits into from
Aug 5, 2022
Merged

Add custom interval to scheduled job view #2143

merged 49 commits into from
Aug 5, 2022

Conversation

yoonthegoon
Copy link
Contributor

@yoonthegoon yoonthegoon commented Aug 4, 2022

Closes: #DNE

What's Changed

Modify Interval column of Scheduling table to display scheduled job's crontab when ScheduledJob.interval is custom.
This removes ambiguity as to how often a custom job is scheduled to run without having to rely on its name.

Before:

image

After:

image

Scheduled jobs with other intervals remain unchanged.

image

TODO

  • Explanation of Change(s)
  • Attached Screenshots, Payload Example

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@yoonthegoon yoonthegoon marked this pull request as ready for review August 5, 2022 13:14
@glennmatthews glennmatthews merged commit 453ec9e into nautobot:develop Aug 5, 2022
glennmatthews added a commit that referenced this pull request Aug 5, 2022
smk4664 added a commit to smk4664/nautobot that referenced this pull request Aug 10, 2022
* next: (24 commits)
  Added release-notes for nautobot#2168
  Add model toggle to skip adding missing Dynamic Group filter fields (nautobot#2168)
  Add release-note for nautobot#2165
  Fix up relationship-association API test issue (nautobot#2165)
  Fix missing RelationshipModelForm class, add @class_deprecated_in_favor_of decorator (nautobot#2151)
  Fix nautobot#2090: don't reset Tag content-types on a PATCH (nautobot#2164)
  Add release-note for nautobot#2106
  Notes api (nautobot#2120)
  Fix release note for nautobot#2150
  Only populate statuses on Integration TestCases. (nautobot#2160)
  fix ObjectChange missing user object when making changes through API (nautobot#2158)
  Fix release note for nautobot#2091
  Feature to Mark an Entire Job's Parameters as Sensitive (nautobot#2125)
  Update release date, version.
  Add release-note for nautobot#2095
  Documenting Redis TLS and adjusting healthcheck. (nautobot#2097)
  Extending filtering of date custom field type (nautobot#2126)
  Bug fixes and add missing API functionality for Dynamic Group Memberships (nautobot#2144)
  Add release-notes for nautobot#2073, nautobot#2080, nautobot#2143
  Add local option to runjob (nautobot#2073)
  ...

# Conflicts:
#	nautobot/docs/development/style-guide.md
#	nautobot/docs/release-notes/version-1.4.md
#	nautobot/extras/forms/base.py
#	nautobot/extras/forms/mixins.py
#	nautobot/extras/tests/test_forms.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants