Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix widget for boolean filters fields when generating filter form for a Dynamic Group #2191

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

jathanism
Copy link
Contributor

Closes: #DNE

What's Changed

This is a quick fix based on an issue raised by @mzbroch.

  • Explicitly map boolean fields to use a NullBooleanField with a widget that allows for a null selection and doesn't default to False when unchecked.

TODO

  • Explanation of Change(s)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

… a Dynamic Group

- Explicitly map boolean fields to use a `NullBooleanField` with a widget that allows for a null selection and doesn't default to `False` when unchecked.
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks reasonable. Anything we can easily do as far as unit test coverage goes?

@bryanculver
Copy link
Member

Should target develop at this point.

@jathanism jathanism changed the base branch from next to develop August 12, 2022 15:04
@jathanism jathanism merged commit 36971f1 into develop Aug 12, 2022
@jathanism jathanism deleted the jathanism-mzb-fixes branch August 12, 2022 15:40
jathanism added a commit that referenced this pull request Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants