Make PR template less dogmatic; add '#' before issue number for clarity #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathanism
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Only thing about having the preceding "#" there is that I think it might not trigger the issue auto-complete. Obviously if somebody already knows the issue number it doesn't matter and it saves a keystroke. More importantly, it also asserts that it will be marked up, since people often leave out the "#".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: N/A
#before the<ISSUE NUMBER GOES HERE>so that issue number references will be appropriately hyperlinked.