Plugin support to add items to the homepage #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
requested changes
Jul 12, 2021
There was a problem hiding this comment.
Looks like a reasonable start to me, thanks! "Requesting changes" as I just left a number of comments on #647 which is as you noted a pre-requisite for this PR. Also please be sure to update the plugin development docs with information about how a plugin is to use this new feature.
Software defined homepage: dynamically reflow columns using CSS
carbonarok
changed the title
| @@ -0,0 +1,3 @@ | |||
| <div class="list-group-item"> | |||
| <a>Site has been overwritten.</a> | |||
| </div> | |||
There was a problem hiding this comment.
Hm. I'm actually not sure I like allowing plugins to replace home page items. Maybe this is something we should check for and block?
There was a problem hiding this comment.
okay sure, i will block this for now
…erwritting panels.
nautobot/core/apps/__init__.py
Outdated
|
|
||
| Args: | ||
| path (str): Path to the app which defines the homepage layout. | ||
| label (str): Label of the app which defines the homepage layout. |
There was a problem hiding this comment.
path and label are only relevant when using custom templates, correct? Otherwise they're unused?
There was a problem hiding this comment.
Correct, i'll add a coment
glennmatthews
approved these changes
Jul 30, 2021
glennmatthews
added a commit
that referenced
this pull request
Jul 30, 2021
hellerve
added a commit
to hellerve/nautobot
that referenced
this pull request
Aug 5, 2021
* origin/next: Add release-notes for nautobot#479, nautobot#674, nautobot#716 Plugin support to add items to the homepage (nautobot#674) Implement a base template for generic object detail views (nautobot#737) Bump version to 1.2.0-alpha.1 nautobot#647 Software Defined Homepage (nautobot#716)
hellerve
added a commit
to hellerve/nautobot
that referenced
this pull request
Aug 12, 2021
* origin/next: (104 commits) Add release-notes for nautobot#479, nautobot#674, nautobot#716 Plugin support to add items to the homepage (nautobot#674) Implement a base template for generic object detail views (nautobot#737) Bump version to 1.2.0-alpha.1 Add release-note for nautobot#727 Bump version to 1.1.1-beta.1 Fix GraphQLQuery run API endpoint. Fixes nautobot#727 (nautobot#730) Implement `FileProxy` and `FileAttachment` objects (nautobot#712) Update computed field GraphQL schema generator to use correct arg name (nautobot#721) Added changelog for nautobot#372 Add support for custom fields in tables (nautobot#469) Bump version for v1.1.0 and prep release notes. Added changelog for nautobot#717 Bump pillow from 8.1.2 to 8.2.0 (nautobot#717) Added changelog for nautobot#691 Celery RQ migration and concurrency (nautobot#691) Add release-note for nautobot#702 Host GraphiQL dependencies statically rather than on CDN. Fixes nautobot#702 (nautobot#714) nautobot#647 Software Defined Homepage (nautobot#716) Added changelog for nautobot#703 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
Merge dependancy #647