Installed plugins view and plugin homepage/configuration links #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dang. Looks like there's something in the |
Merged
hellerve
approved these changes
Sep 24, 2021
jedelman8
approved these changes
Sep 24, 2021
dgarros
reviewed
Sep 28, 2021
| link="plugins:plugins_list", | ||
| name="Installed Plugins", | ||
| weight=100, | ||
| permissions=[], |
There was a problem hiding this comment.
Sorry I'm late to the party,
I think it would be good to have a permission associated with this menu item and this view to allow Nautobot Admin to limit who can access this view
There was a problem hiding this comment.
Currently the view is available to all authenticated users. Since there isn't an actual data model underpinning it, it's a bit tricky to use the object-based permissions framework to restrict the view more narrowly than that. I'm open to suggestions though.
This was referenced Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #580, Relates to #547 and #803
/admin/installed-pluginsadmin-only view and replace it with a/plugins/installed-plugins/view that is accessible to all authenticated users. (part of Migrate user, social auth, and system settings from Django Admin to be first-class citizens in UI/API #547)config_view_nameandhome_view_name. If these are specified by a plugin, the "actions" buttons in the rightmost column of the Installed Plugins table view will use these links (otherwise the buttons will be present but disabled). (Feature Request: Plugins Configuration View #580)dummy_pluginwith some simple page templates.settingsas those may be sensitive)readymethod now stores various additional information on the PluginConfig which is used by this view to display an in-depth view of features used by the pluginutilities/render_boolean.htmltemplate - this is also an attempt to lay groundwork for the eventual implementation of Add templatetag for consistent rendering of boolean values #803.