RPC tests: Fix while loops of cfund tests causing random test fails #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The while loops in these tests are designed to wait until a proposal is expired. However previously, these two tests would fail randomly at the assert immediately following the while loop.
time.time()returns values inconsistent with the block times of the test blockchain, recorded innTimeof each block, sometimes by up to 100s.The purpose of the test is not to compare
time.time()but to test whether a block withnTimeexceeding a proposal's deadline will be correctly marked as expired. Hence the while loop has been revised to reflect this.The running time of these tests is also reduced.
Fixes two tests in #416.