Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.7.0 rc #545

Merged
merged 30 commits into from
Sep 13, 2019
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d48d003
changed version numbers, started working on the release notes.
proletesseract Jun 30, 2019
6f40f24
added vscode workspace file to gitignore
proletesseract Jun 30, 2019
9b5665e
more PR's added
proletesseract Jun 30, 2019
9fc5078
release notes done apart from #544 when it gets merged.
proletesseract Jun 30, 2019
25247c8
removed version numbers from unnecessary files and removed the revert…
proletesseract Jun 30, 2019
9b39290
replaced references to /NAVCoin/ with /navcoin/ to match the updated …
proletesseract Jun 30, 2019
1ea0b42
Merge branch 'master' into v4.7.0-rc
proletesseract Jun 30, 2019
6527368
PR 544 added to release notes
proletesseract Jun 30, 2019
a2921e6
Merge pull request #25 from proletesseract/master
proletesseract Jul 3, 2019
df37e60
Merge pull request #27 from proletesseract/master
proletesseract Jul 5, 2019
5a70b97
Merge pull request #29 from proletesseract/master
proletesseract Jul 8, 2019
c26f98e
updating release notes
proletesseract Jul 8, 2019
ca4eaef
Merge pull request #31 from proletesseract/master
proletesseract Jul 13, 2019
3d6fea6
added more PRs to the release notes
proletesseract Jul 14, 2019
2b13cc9
Merge remote-tracking branch 'origin/v4.7.0-rc' into v4.7.0-rc
proletesseract Jul 14, 2019
d808099
Add new strings
Jul 14, 2019
171ffa4
Merge pull request #32 from aguycalled/v470-strings
proletesseract Jul 18, 2019
d296c93
Merge pull request #34 from proletesseract/master
proletesseract Jul 21, 2019
2baa638
batchwrite simplification
Aug 2, 2019
e15f607
optimize cfundvote function
Aug 8, 2019
c9cad0c
flush db after migration and set flag
Aug 17, 2019
c3bd1c8
fix typo
Aug 17, 2019
efa179d
do not use flag
Aug 17, 2019
275386c
flush not necessary
Aug 17, 2019
b37b781
Merge pull request #36 from aguycalled/v4.7.0-rc-flush-db
proletesseract Aug 23, 2019
25e9863
Merge pull request #35 from aguycalled/optimize-cfundvote
proletesseract Aug 23, 2019
e8696f2
Merge pull request #37 from navcoin/master
proletesseract Aug 23, 2019
cf37230
Merge branch 'v4.7.0-rc' into master
proletesseract Aug 23, 2019
505fe04
Merge pull request #38 from proletesseract/master
proletesseract Aug 23, 2019
eb75e2a
updated release notes
proletesseract Aug 23, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -139,3 +139,5 @@ ui_*.h
*.cflags
*.cxxflags
*.creator.*

navcoin-core\.code-workspace
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
![NavCoin](./img/logo-extended.png)

This is the working repository for NavCoin 4.6.0, our fork of bitcoin-core 0.13.
This is the working repository for NavCoin Core, our fork of bitcoin-core 0.13.

For more information please visit the website:

https://navcoin.org/en/roadmap

[![Build Status](https://travis-ci.org/NAVCoin/navcoin-core.svg?branch=master)](https://travis-ci.org/NAVCoin/navcoin-core)
[![Build Status](https://travis-ci.org/navcoin/navcoin-core.svg?branch=master)](https://travis-ci.org/navcoin/navcoin-core)

## Building

Expand Down
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N)
AC_PREREQ([2.60])
define(_CLIENT_VERSION_MAJOR, 4)
define(_CLIENT_VERSION_MINOR, 6)
define(_CLIENT_VERSION_MINOR, 7)
define(_CLIENT_VERSION_REVISION, 0)
define(_CLIENT_VERSION_BUILD, 0)
define(_CLIENT_VERSION_IS_RELEASE, true)
Expand Down
2 changes: 1 addition & 1 deletion doc/Doxyfile
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ PROJECT_NAME = NavCoin
# This could be handy for archiving the generated documentation or
# if some version control system is used.

PROJECT_NUMBER = 4.6.0
PROJECT_NUMBER = 4.7.0

# Using the PROJECT_BRIEF tag one can provide an optional one line description
# for a project that appears at the top of each page and should give viewer
Expand Down
2 changes: 1 addition & 1 deletion doc/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
NavCoin Core 4.6.0
NavCoin Core
=====================

Setup
Expand Down
2 changes: 1 addition & 1 deletion doc/README_windows.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
NavCoin Core 4.6.0
NavCoin Core
=====================

Intro
Expand Down
2 changes: 1 addition & 1 deletion doc/build-osx.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ Libunbound needs to be compiled from source. Download last version from http://w
1. Clone the navcoin source code and cd into `navcoin`

```bash
git clone https://github.com/NAVCoin/navcoin-core.git
git clone https://github.com/navcoin/navcoin-core.git
cd navcoin-core
```

Expand Down
4 changes: 2 additions & 2 deletions doc/build-unix.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ Some notes on how to build NavCoin Core in Unix.

## Building in Ubuntu 18.04

You can easily build the dependencies by running the [NavCoin dev tools script](https://github.com/NAVCoin/navcoin-dev-tools/blob/master/ubuntu-18.04-navcoin-core-dev-setup.sh) using the command bellow.
You can easily build the dependencies by running the [NavCoin dev tools script](https://github.com/navcoin/navcoin-dev-tools/blob/master/ubuntu-18.04-navcoin-core-dev-setup.sh) using the command bellow.

```bash
curl -o- https://raw.githubusercontent.com/NAVCoin/navcoin-dev-tools/master/ubuntu-18.04-navcoin-core-dev-setup.sh | bash
curl -o- https://raw.githubusercontent.com/navcoin/navcoin-dev-tools/master/ubuntu-18.04-navcoin-core-dev-setup.sh | bash
```

From the navcoin-core directory, you will still need to:
Expand Down
2 changes: 1 addition & 1 deletion doc/gitian-building.md
Original file line number Diff line number Diff line change
Expand Up @@ -493,5 +493,5 @@ Uploading signatures
---------------------

After building and signing you can push your signatures (both the `.assert` and `.assert.sig` files) to the
[NAVCoin/navcoin-sigs](https://github.com/NAVCoin/navcoin-sigs) repository, or if that's not possible create a pull
[NAVCoin/navcoin-sigs](https://github.com/navcoin/navcoin-sigs) repository, or if that's not possible create a pull
request.
2 changes: 1 addition & 1 deletion doc/npips.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
NPIPs (NavCoin Protocol Improvement Proposals) that are implemented by into NavCoin Core:

* [`NPIP 1`](https://github.com/NAVCoin/npips/blob/master/npip-0001.mediawiki): This change details how all protocol improvements will be handled from here on out **v4.2.0** ([PR #209](https://github.com/NAVCoin/navcoin-core/pull/209))
* [`NPIP 1`](https://github.com/navcoin/npips/blob/master/npip-0001.mediawiki): This change details how all protocol improvements will be handled from here on out **v4.2.0** ([PR #209](https://github.com/navcoin/navcoin-core/pull/209))
4 changes: 2 additions & 2 deletions doc/release-notes/release-notes-4.3.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Introduces OpenAlias:

This PR https://github.com/NAVCoin/navcoin-core/pull/213 completes the implementation of the OpenAlias protocol into the NavCoin Core client.
This PR https://github.com/navcoin/navcoin-core/pull/213 completes the implementation of the OpenAlias protocol into the NavCoin Core client.

OpenAlias is an standard created by the Monero Core project used in the Monero wallet and some other clients like Bitcoin Electrum which allows the wallet to translate email addresses into cryptocurrency addresses using custom TXT entries in the DNS records of a domain.

Expand Down Expand Up @@ -31,7 +31,7 @@ We now clasify orphan transactions with a new "Orphan" status and show them in t

## Remove BIGNUM use

This PR https://github.com/NAVCoin/navcoin-core/pull/214 completely removes the use of the OpenSSL's class BIGNUM, substituting the uses of CBigNum with the class uint256 with extended arithmetic capabilities (arith_uint256). OpenSSL deprecated some BIGNUM functions in version 1.1, making the wallet unable to compile in systems which use the newer version. This patch fixes this issue.
This PR https://github.com/navcoin/navcoin-core/pull/214 completely removes the use of the OpenSSL's class BIGNUM, substituting the uses of CBigNum with the class uint256 with extended arithmetic capabilities (arith_uint256). OpenSSL deprecated some BIGNUM functions in version 1.1, making the wallet unable to compile in systems which use the newer version. This patch fixes this issue.

# ZeroMQ Windows Patch

Expand Down
4 changes: 2 additions & 2 deletions doc/release-notes/release-notes-4.4.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ The Version Bit 14 will signal for the soft fork to activate NPIP0003.

This is largely a technical improvement which consolidates mined Community Fund contributions to every 500th block instead of every block to reduce blockchain bloat.

You can read more about [NPIP0003 on the NPIP GitHub](https://github.com/NAVCoin/npips/blob/master/npip-0003.mediawiki).
You can read more about [NPIP0003 on the NPIP GitHub](https://github.com/navcoin/npips/blob/master/npip-0003.mediawiki).

## Community Fund Contribution Increase

The Version Bit 16 will signal for the soft fork to increase the Community Fund contribution from 0.25 NAV to 0.50 NAV per block.

You can read more about [NPIP0005 on the NPIP GitHub](https://github.com/NAVCoin/npips/blob/master/npip-0005.mediawiki).
You can read more about [NPIP0005 on the NPIP GitHub](https://github.com/navcoin/npips/blob/master/npip-0005.mediawiki).

## Reject specific version bits

Expand Down
38 changes: 19 additions & 19 deletions doc/release-notes/release-notes-4.5.0.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

## Cold Staking Protocol Upgrade

<[Pull Request 249](https://github.com/NAVCoin/navcoin-core/pull/249)>
<[Commit b1c776c](https://github.com/NAVCoin/navcoin-core/commit/b1c776c605e5bace1d4f6bee50182b92951fd327 )>
<[Pull Request 249](https://github.com/navcoin/navcoin-core/pull/249)>
<[Commit b1c776c](https://github.com/navcoin/navcoin-core/commit/b1c776c605e5bace1d4f6bee50182b92951fd327 )>

This Protocol Upgrade will implement the [NPIP_0002](https://github.com/NAVCoin/npips/blob/master/npip-0002.mediawiki) which will introduce a new opcode (OP_COINSTAKE) for the NavCoin scripting language and a new standard transaction type using the new opcode.
This Protocol Upgrade will implement the [NPIP_0002](https://github.com/navcoin/npips/blob/master/npip-0002.mediawiki) which will introduce a new opcode (OP_COINSTAKE) for the NavCoin scripting language and a new standard transaction type using the new opcode.

The wallet will vote this Protocol Upgrade with `YES` by default.

Expand Down Expand Up @@ -35,10 +35,10 @@ To not vote for this Protocol Upgrade, add the following line to your `navcoin.c

## Static Rewards Protocol Upgrade

<[Pull Request 328](https://github.com/NAVCoin/navcoin-core/pull/328)>
<[Commit 9601f85](https://github.com/NAVCoin/navcoin-core/commit/9601f8501526cba19ded59ae685e393345ef430c)>
<[Pull Request 328](https://github.com/navcoin/navcoin-core/pull/328)>
<[Commit 9601f85](https://github.com/navcoin/navcoin-core/commit/9601f8501526cba19ded59ae685e393345ef430c)>

This Protocol Upgrade will change the NavCoin Staking block reward to a fixed amount of 2 NAV per block. You can read more about this upgrade at its NPIP page, [NPIP_0004](https://github.com/NAVCoin/npips/blob/master/npip-0004.mediawiki).
This Protocol Upgrade will change the NavCoin Staking block reward to a fixed amount of 2 NAV per block. You can read more about this upgrade at its NPIP page, [NPIP_0004](https://github.com/navcoin/npips/blob/master/npip-0004.mediawiki).

The wallet will vote this Protocol Upgrade with `YES` by default.

Expand All @@ -52,8 +52,8 @@ To reject this Protocol Upgrade, add the following line to your `navcoin.conf` f

## Dynamic Community Fund Quorum Protocol Upgrade

<[Pull Request 328](https://github.com/NAVCoin/navcoin-core/pull/333)>
<[Commit 9601f85](https://github.com/NAVCoin/navcoin-core/commit/c1ea4ac484401d17230cb82481fe17beea168979)>
<[Pull Request 328](https://github.com/navcoin/navcoin-core/pull/333)>
<[Commit 9601f85](https://github.com/navcoin/navcoin-core/commit/c1ea4ac484401d17230cb82481fe17beea168979)>

This Protocol Upgrade would introduce a reduction of the required quorum for the Community Fund in the second half of the votings from 50% to 40%.

Expand All @@ -68,8 +68,8 @@ To accept this Protocol Upgrade, add the following line to your `navcoin.conf` f

## Reject specific version bits by default

<[Pull Request 336](https://github.com/NAVCoin/navcoin-core/pull/336)>
<[Commit eb6a1a2](https://github.com/NAVCoin/navcoin-core/commit/eb6a1a27903a477306a7ef73d3d85bd52ff1f3c4)>
<[Pull Request 336](https://github.com/navcoin/navcoin-core/pull/336)>
<[Commit eb6a1a2](https://github.com/navcoin/navcoin-core/commit/eb6a1a27903a477306a7ef73d3d85bd52ff1f3c4)>

By default the wallet votes yes for the Protocol Upgrades included in the wallet. This change adds a list of version bits which will be voted no by default, while also adding an option to manually vote yes for those bits.

Expand All @@ -78,8 +78,8 @@ To manually vote yes for a version bit add the following to your `navcoin.conf`

## Block header spam protection

<[Pull Request 335](https://github.com/NAVCoin/navcoin-core/pull/335)>
<[Commit 210a22d](https://github.com/NAVCoin/navcoin-core/commit/210a22daaffbd36d90a5ee0121c0c4ce3de0ed75)>
<[Pull Request 335](https://github.com/navcoin/navcoin-core/pull/335)>
<[Commit 210a22d](https://github.com/navcoin/navcoin-core/commit/210a22daaffbd36d90a5ee0121c0c4ce3de0ed75)>

The wallet will now rate-limit the amount of block headers received from a single peer before banning them for misbehaving. This is an anti-spam measure and is customizable via the config file or via launch arguments.

Expand All @@ -93,8 +93,8 @@ The new launch arguments are:

## Community Fund RPC commands

<[Pull Request 334](https://github.com/NAVCoin/navcoin-core/pull/334)>
<[Commit cc8e213](https://github.com/NAVCoin/navcoin-core/commit/cc8e21306cb804671676c6e10c0c2751061e7cc8)>
<[Pull Request 334](https://github.com/navcoin/navcoin-core/pull/334)>
<[Commit cc8e213](https://github.com/navcoin/navcoin-core/commit/cc8e21306cb804671676c6e10c0c2751061e7cc8)>

- Shows help for `proposalvotelist` and `paymentrequestvotelist`.
- Shows proposals and payment requests in pending state without vote.
Expand All @@ -103,9 +103,9 @@ The new launch arguments are:

### Other modifications in the NavCoin client, docs and codebase

- Added github issue and pull request templates. <[Pull Request 347](https://github.com/NAVCoin/navcoin-core/pull/347)> <[Commit ce2e282](https://github.com/NAVCoin/navcoin-core/commit/ce2e28295e97398d538f23d795cf20b0544973b2)>.
- Updated link to bootstrap file in wallet gui. <[Pull Request 338](https://github.com/NAVCoin/navcoin-core/pull/338)> <[Commit 8aa7cdd](https://github.com/NAVCoin/navcoin-core/commit/8aa7cddc74acac9d1e8e5f7eb50627ec064896fe)>.
- Community Fund RPC Tests clean up. <[Pull Request 318](https://github.com/NAVCoin/navcoin-core/pull/318)> <[Commit 7730c7b](https://github.com/NAVCoin/navcoin-core/commit/7730c7bc84256ddb995408c1bc775015f0219d2d)>.
- Fixed changelog link to NPIP. <[Pull Request 317](https://github.com/NAVCoin/navcoin-core/pull/317)> <[Commit f0ea24c](https://github.com/NAVCoin/navcoin-core/commit/f0ea24c2228107f765735ec2136f9f20e6eda456)>.
- Updated link to NavCoin github repo. <[Pull Request 314](https://github.com/NAVCoin/navcoin-core/pull/314)> <[Commit dcdece2](https://github.com/NAVCoin/navcoin-core/commit/dcdece2be47b4ab55b6231024aef2bc20e7d3b0c)>
- Added github issue and pull request templates. <[Pull Request 347](https://github.com/navcoin/navcoin-core/pull/347)> <[Commit ce2e282](https://github.com/navcoin/navcoin-core/commit/ce2e28295e97398d538f23d795cf20b0544973b2)>.
- Updated link to bootstrap file in wallet gui. <[Pull Request 338](https://github.com/navcoin/navcoin-core/pull/338)> <[Commit 8aa7cdd](https://github.com/navcoin/navcoin-core/commit/8aa7cddc74acac9d1e8e5f7eb50627ec064896fe)>.
- Community Fund RPC Tests clean up. <[Pull Request 318](https://github.com/navcoin/navcoin-core/pull/318)> <[Commit 7730c7b](https://github.com/navcoin/navcoin-core/commit/7730c7bc84256ddb995408c1bc775015f0219d2d)>.
- Fixed changelog link to NPIP. <[Pull Request 317](https://github.com/navcoin/navcoin-core/pull/317)> <[Commit f0ea24c](https://github.com/navcoin/navcoin-core/commit/f0ea24c2228107f765735ec2136f9f20e6eda456)>.
- Updated link to NavCoin github repo. <[Pull Request 314](https://github.com/navcoin/navcoin-core/pull/314)> <[Commit dcdece2](https://github.com/navcoin/navcoin-core/commit/dcdece2be47b4ab55b6231024aef2bc20e7d3b0c)>
- New genesis block for testnet.
16 changes: 8 additions & 8 deletions doc/release-notes/release-notes-4.5.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,27 @@

Currently if a node reindexes their chainstate db, the node will recalculate the deadline of expired proposals and rewrite such proposals as accepted. A node which reindexes will end up with a different state and potentially reject blocks containing payment requests causing some users to end up on their own fork of the blockchain.

<[Pull Request 367](https://github.com/NAVCoin/navcoin-core/pull/367)>
<[Commit c59cd80](https://github.com/NAVCoin/navcoin-core/commit/c59cd802e43960ab4ff88dece294dbcecc6bce8e)>
<[Pull Request 367](https://github.com/navcoin/navcoin-core/pull/367)>
<[Commit c59cd80](https://github.com/navcoin/navcoin-core/commit/c59cd802e43960ab4ff88dece294dbcecc6bce8e)>

- This patch ensures the state of previously expired proposals are not rewritten as accepted when a chainstate db is reindexed locally.
- Ensures proper expiry of proposals after their duration has been exceeded.
- Adds tests to check the proper expiry of proposals.

<[Pull Request 370](https://github.com/NAVCoin/navcoin-core/pull/370)>
<[Pull Request 370](https://github.com/navcoin/navcoin-core/pull/370)>

- Fixes the payout of payment requests when the proposal is already expired. Adds a new state for proposals (`PENDING_VOTING_PREQ`) to handle expired proposals with pending payment requests.
- Adds tests to check the correct implementation of this state.

## Static Rewards Hotfix

<[Pull Request 369](https://github.com/NAVCoin/navcoin-core/pull/369)>
<[Commit 88a9060](https://github.com/NAVCoin/navcoin-core/commit/88a9060b80603afdab6dc374ef1144fcb58bc462)>
<[Pull Request 369](https://github.com/navcoin/navcoin-core/pull/369)>
<[Commit 88a9060](https://github.com/navcoin/navcoin-core/commit/88a9060b80603afdab6dc374ef1144fcb58bc462)>

Currently if a block included both a static reward and some transaction(s), the network will reject such blocks since the total amount of fees would be verified incorrectly. This patch fixes the verification and adds tests to check the blocks are correctly accepted.

## Other modifications in the NavCoin client, docs and codebase

- Fixed output of `cfundstats` rpc command. <[Pull Request 374](https://github.com/NAVCoin/navcoin-core/pull/374)> <[Commit fe5f8c7](https://github.com/NAVCoin/navcoin-core/commit/fe5f8c79ea5708692181dfb913e8b17d5517c4ea)>.
- Improvements to core wallet CFund voting window. <[Pull Request 368](https://github.com/NAVCoin/navcoin-core/pull/368)> <[Commit 1b1077b](https://github.com/NAVCoin/navcoin-core/commit/1b1077be384c1a230d7c568a7fa05d4b43a4111b)>
- Minor typo fix to coldstaking wizard. <[Pull Request 364](https://github.com/NAVCoin/navcoin-core/pull/364)> <[Commit 769ff16](https://github.com/NAVCoin/navcoin-core/commit/769ff16b05f70ccfa24adcaf589bfa5a4157c067)>
- Fixed output of `cfundstats` rpc command. <[Pull Request 374](https://github.com/navcoin/navcoin-core/pull/374)> <[Commit fe5f8c7](https://github.com/navcoin/navcoin-core/commit/fe5f8c79ea5708692181dfb913e8b17d5517c4ea)>.
- Improvements to core wallet CFund voting window. <[Pull Request 368](https://github.com/navcoin/navcoin-core/pull/368)> <[Commit 1b1077b](https://github.com/navcoin/navcoin-core/commit/1b1077be384c1a230d7c568a7fa05d4b43a4111b)>
- Minor typo fix to coldstaking wizard. <[Pull Request 364](https://github.com/navcoin/navcoin-core/pull/364)> <[Commit 769ff16](https://github.com/navcoin/navcoin-core/commit/769ff16b05f70ccfa24adcaf589bfa5a4157c067)>
Loading