-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated __poll_chk implementation to be not so strict #549
Updated __poll_chk implementation to be not so strict #549
Conversation
@marcus290 this is a fix for the issue you found. |
Basically I copied logic from glibc: https://sourceware.org/git/?p=glibc.git;a=blob;f=debug/poll_chk.c;h=34596de9777b3fe9f05e8a57840dd75076c51672;hb=HEAD |
Where do the original changes from d3b5687#diff-626fe822220cf08b83b6459ec6c2b29b which introduced the bug come from? |
|
1f948a7
to
b19b0df
Compare
I updated my commit to also remove the header for assert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested debian
building in ubuntu 18.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a 64-bit Linux gitian build on Ubuntu. Not getting the crash anymore
merging in navcoin#549
merging navcoin#549 into RC branch
This fixes a crash for navcoin-qt when libs call poll() with bad data.
Updated the
__poll_chk
to behave less aggressive (More like__explicit_bzero_chk
)Calls
__chk_fail()
instead of an assert which would terminate the execution of the rest of the app