Updated __poll_chk implementation to be not so strict#549
Updated __poll_chk implementation to be not so strict#549mxaddict merged 1 commit intonavcoin:masterfrom
Conversation
|
@marcus290 this is a fix for the issue you found. |
|
Basically I copied logic from glibc: https://sourceware.org/git/?p=glibc.git;a=blob;f=debug/poll_chk.c;h=34596de9777b3fe9f05e8a57840dd75076c51672;hb=HEAD |
|
Where do the original changes from d3b5687#diff-626fe822220cf08b83b6459ec6c2b29b which introduced the bug come from? |
|
|
1f948a7 to
b19b0df
Compare
|
I updated my commit to also remove the header for assert |
|
building in ubuntu 18.04 |
marcus290
left a comment
There was a problem hiding this comment.
Tested on a 64-bit Linux gitian build on Ubuntu. Not getting the crash anymore
merging in navcoin#549
merging navcoin#549 into RC branch
This fixes a crash for navcoin-qt when libs call poll() with bad data.
Updated the
__poll_chkto behave less aggressive (More like__explicit_bzero_chk)Calls
__chk_fail()instead of an assert which would terminate the execution of the rest of the app