Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Wallet false positive on txdata encryption #774

Merged
merged 2 commits into from
Feb 2, 2021
Merged

[FIX] Wallet false positive on txdata encryption #774

merged 2 commits into from
Feb 2, 2021

Conversation

mxaddict
Copy link
Contributor

No description provided.

@navbuilder
Copy link

A new build of 227fdad has completed succesfully!
Binaries available at https://build.nav.community/binaries/fix-false-positive-pin-unlock

@chasingkirkjufell
Copy link
Contributor

the wallet still asks for pin at start for me with the gitian builds

@mxaddict
Copy link
Contributor Author

mxaddict commented Feb 2, 2021

the wallet still asks for pin at start for me with the gitian builds

@chasingkirkjufell I pushed another commit, this should fix the issue on windows.

@chasingkirkjufell
Copy link
Contributor

the wallet still asks for pin at start for me with the gitian builds

@chasingkirkjufell I pushed another commit, this should fix the issue on windows.

great. will test the gitian build

@navbuilder
Copy link

A new build of 1d5c284 has completed succesfully!
Binaries available at https://build.nav.community/binaries/fix-false-positive-pin-unlock

@mxaddict
Copy link
Contributor Author

mxaddict commented Feb 2, 2021

A new build of 1d5c284 has completed succesfully!
Binaries available at https://build.nav.community/binaries/fix-false-positive-pin-unlock

I tested the gitian build with the wallet.dat file that @chasingkirkjufell gave me, and it's now working as expected.

chasingkirkjufell
chasingkirkjufell approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirm fix with previously false locked wallet.dat on windows

@mxaddict
Copy link
Contributor Author

mxaddict commented Feb 2, 2021

confirm fix with previously false locked wallet.dat on windows

@chasingkirkjufell could you share the wallet.dat with @aguycalled so he can use it for testing as well?

@aguycalled
Copy link
Member

tested osx / windows

@aguycalled aguycalled merged commit 4048eb8 into navcoin:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguycalled aguycalled aguycalled approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@dantudor dantudor Awaiting requested review from dantudor

@proletesseract proletesseract Awaiting requested review from proletesseract

@0x2830 0x2830 Awaiting requested review from 0x2830

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mxaddict @navbuilder @chasingkirkjufell @aguycalled