refactor(flow): Remove duplicated condition (#3362)

- Remove duplicated condition "v === 'gridLines.x' - Update test generation options Ref #3360
naver · Aug 23, 2023 · d2bd8ab · d2bd8ab
1 parent c23c62d
commit d2bd8ab
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/src/ChartInternal/interactions/flow.ts b/src/ChartInternal/interactions/flow.ts
@@ -150,9 +150,6 @@ export default {
 			} else if (v === "gridLines.x") {
 				n.attr("x1", isRotated ? 0 : xv)
 					.attr("x2", isRotated ? state.width : xv);
-			} else if (v === "gridLines.x") {
-				n.select("line").attr("x1", isRotated ? 0 : xv)
-					.attr("x2", isRotated ? state.width : xv);
 
 				n.select("text")
 					.attr("x", isRotated ? state.width : 0)

diff --git a/test/api/flow-spec.ts b/test/api/flow-spec.ts
@@ -381,6 +381,9 @@ describe("API flow", () => {
 					type: "line",
 					labels: true
 				},
+				point: {
+					type: "rectangle"
+				},
 				grid: {
 					x: {
 						show: true,

diff --git a/test/interactions/drag-spec.ts b/test/interactions/drag-spec.ts
@@ -146,14 +146,14 @@ describe("DRAG", function() {
 			}, 500);
 		});
 
-		it("set options: data.type='bar'", () => {
-			args.data.type = "pie";
+		it("set options: data.selection.enabled=fasle", () => {
+			args.data.selection.enabled = false;
 		});
 
-		it("pie shouldn't be selected by drag", done => {
+		it("shouldn't be selected by drag", done => {
 			const {internal: {$el}} = chart;
 
-			util.doDrag($el.arcs.node(), {
+			util.doDrag($el.eventRect.node(), {
 				clientX: 34.5,
 				clientY: 20
 			}, {

diff --git a/test/internals/data-spec.ts b/test/internals/data-spec.ts
@@ -1129,8 +1129,6 @@ describe("DATA", () => {
 		afterEach(() => {
 			spyHidden.resetHistory();
 			spyShown.resetHistory();
-
-			chart.destroy();
 		});
 
 		it("check on continuous .hide()/.show() APIs.", function(done) {