Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(interaction): Increase test coverage for interactions #3360

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

netil
Copy link
Member

@netil netil commented Aug 22, 2023

Issue

#3333

Details

  • Reinforce test coverage for interaction related codes
  • Remove unused ‘else’ condition block from .generateTicks()
  • Remove unused ‘jsonTreemp’ module

- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref naver#3333
@netil netil added the test label Aug 22, 2023
@netil netil self-assigned this Aug 22, 2023
@coveralls
Copy link

Coverage Status

coverage: 92.325% (+0.5%) from 91.858% when pulling 041df79 on netil:interaction#3333 into b897cbb on naver:master.

@netil netil merged commit 6333297 into naver:master Aug 22, 2023
10 checks passed
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 23, 2023
- Remove duplicated condition "v === 'gridLines.x'
- Update test generation options

Ref naver#3360
netil pushed a commit to netil/billboard.js that referenced this pull request Aug 23, 2023
- Remove duplicated condition "v === 'gridLines.x'
- Update test generation options

Ref naver#3360
netil added a commit that referenced this pull request Aug 23, 2023
- Remove duplicated condition "v === 'gridLines.x'
- Update test generation options

Ref #3360
netil added a commit that referenced this pull request Sep 5, 2023
- Reinforce test coverage for interaction related codes
- Remove unused ‘else’ condition block from .generateTicks()
- Remove unused ‘jsonTreemp’ module

Ref #3333
netil added a commit that referenced this pull request Sep 5, 2023
- Remove duplicated condition "v === 'gridLines.x'
- Update test generation options

Ref #3360
@netil netil deleted the interaction#3333 branch September 8, 2023 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants