Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

double click event when zoom drag #2104

Closed
mpushki opened this issue May 24, 2021 · 4 comments
Closed

double click event when zoom drag #2104

mpushki opened this issue May 24, 2021 · 4 comments

Comments

@mpushki
Copy link

mpushki commented May 24, 2021

Description

I need to add processing by clicking on a line or dot

  1. Is it possible to add a handler to whole line
  2. Event calls twice when zoom = drag
bb.generate({
  data: {
    xs: {
      data1: "x1",
      data2: "x2"
    },
    columns: [
	    ["x1", 1, 2, 3, 4, 5],
            ["x2", 1, 2, 4, 5, 6],
	    ["data1", 4, 1, 6, 8, 10],
            ["data2", 5, 2, 6, 7, 8]
    ],
    type: "line", // for ESM specify as: line()
    onclick: (d) => {
    	console.log('hi')
    },
  },
  zoom: {
    	enabled: true,
    	type: "drag",
    },
  bindto: "#multipleXYLineChart"
});

Steps to check or reproduce

https://jsfiddle.net/mpushki/7a1xqm9w/15/

@watnab
Copy link

watnab commented May 25, 2021

$$.clickHandlerForMultipleXS.bind(this)($$);

$$.clickHandlerForMultipleXS.bind(this)($$);

@watnab
Copy link

watnab commented May 25, 2021

    onclick: (d) => {
    	console.log(['hi', this.event.type])
    },

may log "mouseup" or "click".

@watnab
Copy link

watnab commented May 25, 2021

Event calls once when xs is omitted.

@netil
Copy link
Member

netil commented May 27, 2021

  1. Is it possible to add a handler to whole line

you can bind event directly to the svg element by:

  onafterinit: function() {
	this.$.line.lines.each(function() {
		// remove inline pointer-events to receive event
		this.parentNode.parentNode.removeAttribute("style");

		this.addEventListener("click", e => {
			console.log(e.target, "clicked the line");
		});
	});

but will notice clicking line element is little bit harder, because the line shape is very thiner.

  1. Event calls twice when zoom = drag

It happens when zoom.drag option is used.
The click event listener was set to fix #583, but it seems working fine removing it from the zoom drag flow.
I'll do the fix.

netil added a commit to netil/billboard.js that referenced this issue May 27, 2021
Remove data.onclick call from zoom drag 'end' event

Ref naver#2104
@netil netil closed this as completed in b4c5dc2 May 27, 2021
github-actions bot pushed a commit that referenced this issue Jun 25, 2021
# [3.1.0](3.0.3...3.1.0) (2021-06-25)

### Bug Fixes

* **axis:** Fix axis.x.padding value setting ([5b4b509](5b4b509)), closes [#2038](#2038)
* **axis:** fix handling x padding value ([489d47a](489d47a)), closes [#2038](#2038)
* **candlestick:** fix to set expand state ([a055b20](a055b20)), closes [#2036](#2036)
* **Chart:** Handle nullish properties from API extendings safely ([6cbf64a](6cbf64a)), closes [#2132](#2132) [#2134](#2134)
* **data:** Fix duplicated data.onclick call  ([b4c5dc2](b4c5dc2)), closes [#2104](#2104)
* **data:** Fix nullish data filtering for grouped data ([af19370](af19370)), closes [#2096](#2096)
* **gauge:** Fix incorrect rendering when gauge.min is given ([31fc981](31fc981)), closes [#2123](#2123)
* **point:** Fix custom point for nullish data ([8c198f2](8c198f2)), closes [#2107](#2107)
* **region:** fix region append position ([2b50443](2b50443)), closes [#2067](#2067)
* **size:** enhance applying height value ([0664a60](0664a60)), closes [#2086](#2086)
* **tooltip:** Correct the type of selectedData ([05b694d](05b694d)), closes [#2056](#2056) [#2058](#2058)
* **types:** fix missing candlestick export ([f218939](f218939)), closes [#2007](#2007)
* **types:** updated bar/candlestick options types ([d89c3f3](d89c3f3)), closes [#2043](#2043)
* **zoom:** Fix incorrect tooltip position ([689bfdf](689bfdf)), closes [#2095](#2095)
* **zoom,grid:** fix grid line pos during zoom ([e84a4f1](e84a4f1)), closes [#2156](#2156)

### Features

* **all:** contain inline css prop setting ([fde6a89](fde6a89)), closes [#2076](#2076)
* **api:** Intent to ship append load ([8076795](8076795)), closes [#2140](#2140)
* **data:** Intent to ship data.onshown/onhidden ([af98eb7](af98eb7)), closes [#2146](#2146)
* **data.labels:** Intent to ship data.labels.backgroundColors ([e0b2fed](e0b2fed)), closes [#1954](#1954)
* **subchart:** Intent to ship subchart.init.range option ([967bf1b](967bf1b)), closes [#2037](#2037)
* **subchart:** Intent to ship subchart.showHandle ([219bff3](219bff3)), closes [#2044](#2044)
netil pushed a commit that referenced this issue Jun 25, 2021
* **Chart:** Handle nullish properties from API extendings safely ([6cbf64a](6cbf64a)), closes [#2132](#2132) [#2134](#2134)
* **data:** Fix duplicated data.onclick call  ([b4c5dc2](b4c5dc2)), closes [#2104](#2104)
* **data:** Fix nullish data filtering for grouped data ([af19370](af19370)), closes [#2096](#2096)
* **gauge:** Fix incorrect rendering when gauge.min is given ([31fc981](31fc981)), closes [#2123](#2123)
* **point:** Fix custom point for nullish data ([8c198f2](8c198f2)), closes [#2107](#2107)
* **region:** fix region append position ([2b50443](2b50443)), closes [#2067](#2067)
* **size:** enhance applying height value ([0664a60](0664a60)), closes [#2086](#2086)
* **tooltip:** Correct the type of selectedData ([05b694d](05b694d)), closes [#2056](#2056) [#2058](#2058)
* **zoom:** Fix incorrect tooltip position ([689bfdf](689bfdf)), closes [#2095](#2095)
* **zoom,grid:** fix grid line pos during zoom ([e84a4f1](e84a4f1)), closes [#2156](#2156)

* **all:** contain inline css prop setting ([fde6a89](fde6a89)), closes [#2076](#2076)
* **api:** Intent to ship append load ([8076795](8076795)), closes [#2140](#2140)
* **data:** Intent to ship data.onshown/onhidden ([af98eb7](af98eb7)), closes [#2146](#2146)
* **data.labels:** Intent to ship data.labels.backgroundColors ([e0b2fed](e0b2fed)), closes [#1954](#1954)
* **subchart:** Intent to ship subchart.init.range option ([967bf1b](967bf1b)), closes [#2037](#2037)
* **subchart:** Intent to ship subchart.showHandle ([219bff3](219bff3)), closes [#2044](#2044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants