Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x axis labels are not reorganized with culling max set when using load() #2582

Closed
heppa opened this issue Mar 7, 2022 · 2 comments
Closed
Assignees
Labels

Comments

@heppa
Copy link

heppa commented Mar 7, 2022

Description

When setting a culling max value for the x axis label to only show a maximum number of labels and then using the load API method to have more data displayed and then using load again with fewer data, the x axis labels are not reset again => eventually when using load more often to update data (eg. via a time periods slider), this leads to having no periods displayed on the x axis at all.

In the example jsFiddle, by pressing the "Get more data" button first and then the "Get back again" button demonstrates this behaviour.

Steps to check or reproduce

(https://codepen.io/alexhepp/pen/YzEMeBL)

@netil netil self-assigned this Mar 8, 2022
@netil netil added the bug label Mar 8, 2022
@netil
Copy link
Member

netil commented Mar 8, 2022

Hi @heppa, confirmed and I'll check the issue. Thanks!

netil added a commit to netil/billboard.js that referenced this issue Mar 8, 2022
Make text node's visibility to be updated from the possible
visibility status.

Ref naver#2582
@netil netil closed this as completed in 4c79daf Mar 8, 2022
@heppa
Copy link
Author

heppa commented Mar 8, 2022

Many thanks for fixing this issue so quickly and also for the awesome library!!! Amazing support!

github-actions bot pushed a commit that referenced this issue Mar 16, 2022
# [3.4.0-next.1](3.3.3...3.4.0-next.1) (2022-03-16)

### Bug Fixes

* **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582)
* **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571)
* **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585)

### Features

* **module:** Support dual CJS/ESM package ([437c007](437c007)), closes [#2202](#2202)
* **plugin:** Intent to ship TableView plugin ([215b611](215b611)), closes [#1873](#1873)
* **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)
github-actions bot pushed a commit that referenced this issue Mar 31, 2022
# [3.4.0](3.3.3...3.4.0) (2022-03-31)

### Bug Fixes

* **api:** Fix flow on indexed/category axis type ([4aba436](4aba436)), closes [#2595](#2595)
* **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582)
* **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571)
* **generator:** Prevent possible infinite loop when tab isn't visible ([bafdb17](bafdb17)), closes [#2606](#2606)
* **option:** Fix data.hide not working for bubble/scatter type ([64ae74b](64ae74b)), closes [#2609](#2609)
* **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585)
* **util:** Enhance parsing date string ([8d9f422](8d9f422)), closes [#1714](#1714)

### Features

* **api:** Implement axis range reset ([6c9d99e](6c9d99e)), closes [#2398](#2398)
* **option:** Intent to ship onclick ([63c5a53](63c5a53)), closes [#2587](#2587)
* **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants